Skip to content

Use resource id instead of document name #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brunopagno merged 1 commit into from
Nov 25, 2025
Merged

Use resource id instead of document name #14

brunopagno merged 1 commit into from
Nov 25, 2025

Conversation

@brunopagno
Copy link
Contributor

@brunopagno brunopagno commented Nov 25, 2025 •
edited
Loading

@brunopagno brunopagno self-assigned this Nov 25, 2025
@brunopagno brunopagno force-pushed the impl/69240-use-resourceid-instead-of-docname branch from eca27a9 to 361b2c0 Compare November 25, 2025 14:50
@brunopagno brunopagno mentioned this pull request Nov 25, 2025
Merged
3 tasks
@brunopagno brunopagno requested a review from a team November 25, 2025 15:12
judithroth
judithroth approved these changes Nov 25, 2025
View reviewed changes
Copy link

@judithroth judithroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this turned out 👍 so much more cleaned up!

src/extensions/openProjectApi.ts
*/
async onStoreDocument(data: onStoreDocumentPayload): Promise<void> {
const { documentId, opBasePath, readonly } = data.context;
const { resourceUrl, readonly } = data.context;
Copy link

@judithroth judithroth Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much more elegant 😍

test/extensions/openProjectApi.test.ts
new OpenProjectApi().onAuthenticate({
token: "7u+b+QRJN7qANls=--URNw83hIWBq3MMIA--jtl+UPdtbniQVFNOs2EcAw==",
requestParameters: new URLSearchParams({ document_id: "121" }),
// Invalid token, generated with a different secret
Copy link

@judithroth judithroth Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this comment!

@brunopagno brunopagno marked this pull request as ready for review November 25, 2025 18:08
@brunopagno brunopagno merged commit e95c5bb into dev Nov 25, 2025
4 checks passed
@brunopagno brunopagno deleted the impl/69240-use-resourceid-instead-of-docname branch November 25, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@judithroth judithroth judithroth approved these changes

Assignees

@brunopagno brunopagno

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brunopagno @judithroth