Use resource id instead of document name for Hocuspocus #21157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopagno
force-pushed
the
impl/69240-use-resourceid-instead-of-docname
branch
from
bb89038 to
f1c0ea1
Compare
judithroth
approved these changes
Nov 25, 2025
Contributor
judithroth
left a comment
judithroth
left a comment
There was a problem hiding this comment.
🥳 Nice how most of this PR is removing stuff that is no longer necessary 😄
| connect():void { | ||
| const url = new URL(this.hocuspocusUrlValue); | ||
| url.searchParams.set('document_id', this.documentIdValue); | ||
| url.searchParams.set('openproject_base_path', this.openProjectUrlValue); |
Contributor
There was a problem hiding this comment.
It's so nice how this turned out 🤩
brunopagno
force-pushed
the
impl/69240-use-resourceid-instead-of-docname
branch
from
f1c0ea1 to
7681259
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/69240/activity
counterpart of opf/op-blocknote-hocuspocus#14
What are you trying to accomplish?
Use a better key for communicating between OpenProject and Hocuspocus. Also fix issues where changing the document name, or having multiple documents with the same name would cause misalignment with Hocuspocus.
Additionally this simplifies the Hocuspocus setup, we don't need as many parameters, just a resource link.
Merge checklist