Skip to content

[71380] Inplace edit for project attributes on project overview page#21972

Merged
HDinger merged 32 commits intodevfrom
feature/71380-inplace-edit-for-project-attributes-on-project-overview-page
Mar 23, 2026
Merged

[71380] Inplace edit for project attributes on project overview page#21972
HDinger merged 32 commits intodevfrom
feature/71380-inplace-edit-for-project-attributes-on-project-overview-page

Conversation

@HDinger
Copy link
Copy Markdown
Contributor

@HDinger HDinger commented Feb 12, 2026 •
edited
Loading

Ticket

https://community.openproject.org/wp/71380

What are you trying to accomplish?

  • Enable inplaceEditing for project attributes on the overview page
  • Extend the inplaceEdit logic to support
    • all possible field types
    • fields that open in a dialog

Todo

  • Register CustomFields for inplaceEditing
  • Add missing field types for all existing custom field types
    • Integer
    • Float
    • Date
    • Calculated values
    • Boolean
    • Link
    • Version
    • User
    • List
    • Hierarchy
    • Weighted item list
  • Show labels and captions around the field
  • Special look and feel for Calculated values
    • Show calucaltion error
  • Fields that have a comment enabled should still be opened in a dialog
    • Even if the user does not have the permission to edit the field, they need to be able to see the comment in the dialog
  • LongTextFields in the sidebar should also be opened in a dialog because of lack of space
  • Enable marking text while not triggering the inplaceEdit
  • Remove old implementation

Technical

  • Check doubled initialization of DisplayFields
  • Editing project attributes now requires edit_project_attributes as well as edit_project permission. This is different than before but consistent with the API. There is a separate bug to change that again.

Screenshots

Mar-12-2026 12-01-49

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@HDinger HDinger added this to the 17.2.x milestone Feb 12, 2026
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from e01de87 to 41915ca Compare February 13, 2026 09:44
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from b1029b3 to b1476e3 Compare February 16, 2026 14:17
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 2558874 to 7d88b14 Compare February 23, 2026 09:49
@HDinger
Merge remote-tracking branch 'origin/dev' into feature/71380-inplace-…
3541a96 
…edit-for-project-attributes-on-project-overview-page
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 7d88b14 to 3541a96 Compare March 10, 2026 07:55
@HDinger HDinger modified the milestones: 17.2.x, 17.3.x Mar 12, 2026
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 53bdd05 to 0f4f0d1 Compare March 13, 2026 13:19
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 8ce0e3c to ee83264 Compare March 18, 2026 13:04
oliverguenther
oliverguenther reviewed Mar 19, 2026
View reviewed changes
...components/open_project/common/inplace_edit_fields/display_fields/display_field_component.rb
Comment on lines -51 to +59
if value.present?
format_text(value)
if value.is_a?(TrueClass) || value.is_a?(FalseClass)
boolean_display_value(value)
elsif value.is_a?(Date) || value.is_a?(Time)
helpers.format_date(value)
elsif value.present? && value != [nil]
format_present_value(value)
Copy link
Copy Markdown
Member

@oliverguenther oliverguenther Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore if you already decided against it. But a CustomValue has a formatted_value method which in many cases uses the same logic as defined here. we might be able to delegate to it?

Copy link
Copy Markdown
Contributor Author

@HDinger HDinger Mar 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That makes things slightly easier 👍

The formatting is actually not behaving as we want. It deals with default values and user fields differently than what we expect. So I reverted that for now. We can tackle that separately

@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 79a44ad to 150560d Compare March 19, 2026 09:19
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch 2 times, most recently from a97e719 to 71921d3 Compare March 19, 2026 10:32
@HDinger HDinger marked this pull request as ready for review March 19, 2026 10:33
oliverguenther
oliverguenther reviewed Mar 19, 2026
View reviewed changes
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 71921d3 to 9c820cc Compare March 19, 2026 14:13
@HDinger HDinger force-pushed the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch from 9c820cc to 2d92b5d Compare March 20, 2026 07:43
@HDinger HDinger requested a review from oliverguenther March 20, 2026 08:21
@HDinger HDinger mentioned this pull request Mar 20, 2026
Merged
oliverguenther
oliverguenther reviewed Mar 23, 2026
View reviewed changes
oliverguenther
oliverguenther approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more remark that may or may not apply. Would be fine for me to address separately. 👍

@HDinger
Copy link
Copy Markdown
Contributor Author

HDinger commented Mar 23, 2026

I have one more remark that may or may not apply. Would be fine for me to address separately. 👍

Awesome 👍 I fixed the remark you had, waiting for the CI now

@HDinger HDinger merged commit 141ae1a into dev Mar 23, 2026
20 checks passed
@HDinger HDinger deleted the feature/71380-inplace-edit-for-project-attributes-on-project-overview-page branch March 23, 2026 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees

No one assigned

Labels

feature

Milestone

17.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@HDinger @oliverguenther