[#72873] Template drop-down is not showing if user starts meeting creation from global meeting index #22500
Merged
mrmir merged 3 commits intorelease/17.3from Mar 27, 2026
Conversation
596e22e to
0c4f195
Compare
This comment was marked as resolved.
This comment was marked as resolved.
oliverguenther
requested changes
Mar 26, 2026
Member
oliverguenther
left a comment
There was a problem hiding this comment.
I get an internal error when:
- Open global create dialog
- Fill in project that has template
- Fill in template
- Leave title empty
Click save.
The stack trace is
F, [2026-03-26T16:06:30.635866 #41665] FATAL -- : [fab9c796-4024-4c45-9609-944fe9d4c515]
[fab9c796-4024-4c45-9609-944fe9d4c515] NoMethodError (undefined method 'id' for nil):
[fab9c796-4024-4c45-9609-944fe9d4c515]
[fab9c796-4024-4c45-9609-944fe9d4c515] modules/meeting/app/models/meeting.rb:154:in 'Meeting.templates_visible_in_project'
[fab9c796-4024-4c45-9609-944fe9d4c515] modules/meeting/app/controllers/meetings_controller.rb:597:in 'MeetingsController#find_copy_from_meeting'
It seems that this is called with a @project nil value in the error case. Rest of the behavior LGTM.
oliverguenther
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/72873
What approach did you choose and why?
templates_visible_globallyis the new method that enables this check, and is similar totemplates_visible_in_project, but for all projects that a user has permissions forMerge checklist