Skip to content

[#73415] Align Backlog Inbox and Sprint headers#22532

Merged
myabc merged 2 commits intorelease/17.3from
bug/73415-inbox-and-sprints-alignment
Mar 26, 2026
Merged

[#73415] Align Backlog Inbox and Sprint headers#22532
myabc merged 2 commits intorelease/17.3from
bug/73415-inbox-and-sprints-alignment

Conversation

@myabc
Copy link
Copy Markdown
Contributor

@myabc myabc commented Mar 26, 2026

Note

This PR is based off #22524. Please review/merge first.

Ticket

https://community.openproject.org/wp/73415

What are you trying to accomplish?

Align the Inbox and Sprints section headers on the sprint planning page. The turbo-frame wrapper around the Inbox component was creating extra layout space, and both Subhead components had excessive bottom padding.

Screenshots

Before After
Screenshot 2026-03-26 at 17 36 05 Screenshot 2026-03-26 at 17 36 55

What approach did you choose and why?

  • Added display:contents to the Inbox turbo-frame wrapper so it becomes transparent to the parent layout. This pattern is already used in grids/widget_box_component.rb. Primer's display: system argument doesn't support :contents, so inline style: is necessary.
  • Set pb: 0 on both Subhead components to remove bottom padding and achieve consistent spacing.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Backlogs sprint planning UI so the Inbox and Sprints sections align consistently (ticket #73415).

Changes:

  • Removes bottom padding from the Primer::Beta::Subhead in both the sprint list and inbox header (pb: 0).
  • Makes the Inbox component’s turbo-frame wrapper layout-neutral via style: "display:contents" to avoid affecting alignment.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modules/backlogs/app/views/rb_master_backlogs/_sprint_planning_list.html.erb Removes Subhead bottom padding to align the Sprints header with neighboring content.
modules/backlogs/app/components/backlogs/inbox_component.html.erb Makes the wrapper turbo-frame not contribute to layout and removes Subhead bottom padding for consistent vertical alignment.

@myabc myabc changed the title Bug/73415 inbox and sprints alignment [#73415] Align Backlog Inbox and Sprint headers Mar 26, 2026
@myabc myabc force-pushed the bug/73415-inbox-and-sprints-alignment branch from 6ee5e08 to 090f211 Compare March 26, 2026 17:34
@myabc myabc marked this pull request as ready for review March 26, 2026 17:39
@myabc myabc added bugfix needs review styling ruby Pull requests that update Ruby code labels Mar 26, 2026
Base automatically changed from bug/73462-inbox-counter-misaligned to release/17.3 March 26, 2026 18:08
@myabc myabc force-pushed the bug/73415-inbox-and-sprints-alignment branch from 090f211 to 3dbe543 Compare March 26, 2026 18:19
@EinLama EinLama self-requested a review March 26, 2026 18:29
Copy link
Copy Markdown
Contributor

@EinLama EinLama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about display: contents 💡 As it happens, I will need that soon. Good to know!

@myabc myabc force-pushed the bug/73415-inbox-and-sprints-alignment branch from 3dbe543 to 5a40864 Compare March 26, 2026 19:06
@myabc myabc merged commit acd2ca8 into release/17.3 Mar 26, 2026
14 checks passed
@myabc myabc deleted the bug/73415-inbox-and-sprints-alignment branch March 26, 2026 19:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix needs review ruby Pull requests that update Ruby code styling

Development

Successfully merging this pull request may close these issues.

3 participants