[#61630] Danger Dialog should use alertdialog ARIA role#246
Merged
Conversation
Danger dialogs (both the confirmation and default, warning variant) clearly adhere to the alert dialog pattern: > The alertdialog role is to be used on modal alert dialogs that > interrupt a user's workflow to communicate an important message and > require a response. See: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alertdialog_role
🦋 Changeset detectedLatest commit: 9b76502 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
10 tasks
HDinger
reviewed
Feb 20, 2025
Collaborator
HDinger
left a comment
HDinger
left a comment
There was a problem hiding this comment.
Looks good, except for this one change where I am wondering whether this was added by accident?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Improve semantics for users of assistive technology.
Screenshots
No visual changes
Integration
No.
List the issues that this change affects.
https://community.openproject.org/wp/61630
Risk Assessment
What approach did you choose and why?
Danger dialogs (both the confirmation and default, warning variant) clearly adhere to the alert dialog pattern:
See: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alertdialog_role
Anything you want to highlight for special attention from reviewers?
N/A
Accessibility
Merge checklist