Skip to content

Fix #5959 Profiles Flicker issue #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsadityaaaaa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix #5959 Profiles Flicker issue #6063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion app/src/main/java/org/oppia/android/app/recyclerview/BindableAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import androidx.databinding.ViewDataBinding
import androidx.fragment.app.Fragment
import androidx.lifecycle.LifecycleOwner
import androidx.recyclerview.widget.RecyclerView
import org.oppia.android.app.profile.ProfileItemViewModel
import java.lang.ref.WeakReference
import javax.inject.Inject
import kotlin.reflect.KClass
Expand Down Expand Up @@ -36,10 +37,23 @@ class BindableAdapter<T : Any> internal constructor(
) : RecyclerView.Adapter<BindableAdapter.BindableViewHolder<T>>() {
private val dataList: MutableList<T> = ArrayList()

// TODO(#170): Introduce support for stable IDs.
init {
setHasStableIds(true)
}

override fun getItemId(position: Int): Long {
val item = dataList[position]
return when (item) {
is ProfileItemViewModel -> item.profile.id.internalId.toLong()
else -> position.toLong()
}
}

/** Sets the data of this adapter. This is expected to be called by Android via data-binding. */
fun setData(newDataList: List<T>) {
if (dataList == newDataList) {
return
}
dataList.clear()
dataList += newDataList
// TODO(#171): Introduce diffing to notify subsets of the view to properly support animations
Expand Down
Loading