Skip to content

Restraint store.get() when a Kind is provided #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Restraint store.get() when a Kind is provided #321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5689eee
fix store.get()
BeArchiTek Mar 25, 2025
2f40702
linter
BeArchiTek Mar 25, 2025
d2a38b5
uniformize the 2 exception messages
BeArchiTek Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions infrahub_sdk/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,28 +46,25 @@ def _set(self, node: InfrahubNode | InfrahubNodeSync | SchemaType, key: str | No

def _get(self, key: str, kind: str | type[SchemaType] | None = None, raise_when_missing: bool = True): # type: ignore[no-untyped-def]
kind_name = get_schema_name(schema=kind)
if kind_name and kind_name not in self._store and key not in self._store[kind_name]: # type: ignore[attr-defined]
if kind_name:
if kind_name in self._store and key in self._store[kind_name]: # type: ignore[attr-defined]
return self._store[kind_name][key] # type: ignore[attr-defined]
if not raise_when_missing:
return None
raise NodeNotFoundError(
node_type=kind_name,
identifier={"key": [key]},
message="Unable to find the node in the Store",
message=f"Unable to find the node {key!r} in the Store for the specified kind",
)

if kind_name and kind_name in self._store and key in self._store[kind_name]: # type: ignore[attr-defined]
return self._store[kind_name][key] # type: ignore[attr-defined]

for item in self._store.values(): # type: ignore[attr-defined]
if key in item:
return item[key]

if not raise_when_missing:
return None
raise NodeNotFoundError(
node_type="n/a",
identifier={"key": [key]},
message=f"Unable to find the node {key!r} in the store",
message=f"Unable to find the node {key!r} in the Store",
)

def _get_by_hfid(self, key: str, raise_when_missing: bool = True): # type: ignore[no-untyped-def]
Expand Down