Skip to content

Conversation

@dgarros
Copy link
Contributor

@dgarros dgarros commented Apr 13, 2025

  • Update pytest-httpx and set all responses as reusable (required by the latest version of pytest-httpx
  • Add a fixture to always reset some environment variables before running tests
  • Fix type for metadata in InfrahubFileData

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: e40d942
Status: ✅  Deploy successful!
Preview URL: https://a5cbe7ac.infrahub-sdk-python.pages.dev
Branch Preview URL: https://dga-20250413-housekeeping.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop     #354   +/-   ##
========================================
  Coverage    72.45%   72.45%           
========================================
  Files           91       91           
  Lines         8180     8180           
  Branches      1576     1576           
========================================
  Hits          5927     5927           
  Misses        1841     1841           
  Partials       412      412           
Flag Coverage Δ
integration-tests 22.33% <0.00%> (ø)
python-3.10 46.51% <100.00%> (-0.03%) ⬇️
python-3.11 46.51% <100.00%> (ø)
python-3.12 46.51% <100.00%> (-0.03%) ⬇️
python-3.13 46.54% <100.00%> (ø)
python-3.9 44.88% <100.00%> (ø)
python-filler-3.12 25.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/yaml.py 78.48% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dgarros dgarros marked this pull request as ready for review April 13, 2025 13:32
@dgarros dgarros requested a review from a team April 13, 2025 13:32

for name in ENV_VARS_TO_CLEAN:
if original_values[name] is not None:
os.environ[name] = original_values[name]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this will run until the session has completed I don't know if there's a point of resetting the environment variables after everything has completed. There should be nothing left that would use them at that point.

@dgarros dgarros merged commit 757331b into develop Apr 14, 2025
18 checks passed
@dgarros dgarros deleted the dga-20250413-housekeeping branch April 14, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants