Fix optional relationships preventing object template defaults from applying #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating nodes with object templates, the SDK was including explicit
nullvalues for uninitialized optional relationships. The backend interprets these as user overrides, preventing template defaults from being applied.Root cause:
_generate_input_data()unconditionally addedNonefor all optional cardinality-one relationships, regardless of whether the node was new or being updated.Changes:
infrahub_sdk/node/node.py): Omit optional relationships for new nodes; includeNoneonly for existing nodes to preserve ability to clear valuestests/unit/sdk/test_node.py): Updated expectations for new nodes, added coverage for existing node behaviorBefore:
After:
This preserves the existing behavior for updates (PR #515) where
Noneallows explicitly clearing relationship values.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/opsmill/infrahub-sdk-python/pulls/515curl -s REDACTED(http block)mock/home/REDACTED/.cache/pypoetry/virtualenvs/infrahub-sdk-aoa6suxx-py3.12/bin/python /home/REDACTED/.cache/pypoetry/virtualenvs/infrahub-sdk-aoa6suxx-py3.12/bin/pytest tests/unit/ -v(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.