Skip to content

[FSSDK-10989] refactor notification center using event emitter #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 11, 2024
Merged

[FSSDK-10989] refactor notification center using event emitter #975

merged 7 commits into from
Dec 11, 2024

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Dec 10, 2024 •
edited
Loading

Summary

  • the notification center api is basically a slightly different version of the event emitter which we are already using in other components. This PR refactors notification center using the event emitter. This will allow us to achieve a slightly smaller bundle size.

Test plan

  • updated tests accordingly

Issues

  • FSSDK-10989

@raju-opti raju-opti requested a review from a team as a code owner December 10, 2024 19:20
@coveralls
Copy link

coveralls commented Dec 10, 2024 •
edited
Loading

Coverage Status

coverage: 87.005% (+0.09%) from 86.916%
when pulling f4d7a23 on raju/notification-center
into c2880e9 on master.

@raju-opti raju-opti changed the title [FSSDK-10989] refactor notification center types [FSSDK-10989] refactor notification center using event emitter Dec 10, 2024
junaed-optimizely
junaed-optimizely approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some very minor changes..

@raju-opti raju-opti force-pushed the raju/notification-center branch from 93b5853 to b24cdc9 Compare December 11, 2024 17:35
@raju-opti raju-opti merged commit e119925 into master Dec 11, 2024
16 of 19 checks passed
@raju-opti raju-opti deleted the raju/notification-center branch December 11, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely