Skip to content

Launch JShell by creating jshell terminal directly #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2025
Merged

Launch JShell by creating jshell terminal directly #485

merged 1 commit into from
Oct 12, 2025

Conversation

shivam71
Copy link
Member

Removes the need to create and pass environment variables which was causing issues as different shells have different env variable access syntax.

@shivam71
Launch JShell by creating jshell terminal directly.
f98039c 
Removes the need to create and pass environment variables which was causing issues as different shells have different env variable access syntax.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 11, 2025
sid-srini
sid-srini approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @shivam71. LGTM 👍

In the future, you may add that if jshell didn't exist in the supplied jdkPath, as would be the case for JDK8 project.jdkhome, then the extension runtime jdkhome path may be used.

Achal1607
Achal1607 approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @shivam71!

@Achal1607 Achal1607 merged commit 97dee5d into oracle:main Oct 12, 2025
3 checks passed
@sid-srini sid-srini added this to the JVSC 25.0.0 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Achal1607 Achal1607 Achal1607 approved these changes

@sid-srini sid-srini sid-srini approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

JVSC 25.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shivam71 @Achal1607 @sid-srini