Skip to content

Launch JShell by creating jshell terminal directly #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

Launch JShell by creating jshell terminal directly #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions vscode/src/commands/notebook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,11 @@ const openJshellInContextOfProject = async (ctx: any) => {
if (await isNbCommandRegistered(nbCommands.openJshellInProject)) {
const additionalContext = window.activeTextEditor?.document.uri.toString();
const res = await commands.executeCommand<openJshellNbResponse>(nbCommands.openJshellInProject, ctx?.toString(), additionalContext);
const { envMap, finalArgs } = passArgsToTerminal(res.vmOptions);
const jshellPath = res.jdkPath ? path.join(res.jdkPath, "bin", "jshell") : "jshell";
// Direct sendText is not working since it truncates the command exceeding a certain length.
// Open issues on vscode: 130688, 134324 and many more
// So, workaround by setting env variables.
const jshell = os.type() === 'Windows_NT' ? 'jshell.exe' : 'jshell';
const jshellPath = res.jdkPath ? path.join(res.jdkPath, "bin", jshell) : "jshell";
const terminal = window.createTerminal({
name: "Jshell instance", env: envMap
name: "Jshell instance", shellPath: jshellPath, shellArgs: res.vmOptions
});
terminal.sendText(`${jshellPath} ${finalArgs.join(' ')}`, true);
terminal.show();
} else {
throw l10n.value("jdk.extension.error_msg.doesntSupportJShellExecution", { client: client?.name });
Expand All @@ -148,20 +144,6 @@ const openJshellInContextOfProject = async (ctx: any) => {
LOGGER.error(`Error occurred while launching jshell in project context : ${isError(error) ? error.message : error}`);
}
}

const passArgsToTerminal = (args: string[]): { envMap: { [key: string]: string }, finalArgs: string[] } => {
const envMap: { [key: string]: string } = {};
const finalArgs = args.map((arg, index) => {
if (arg.startsWith('-') || arg.startsWith('--')) {
return arg;
}
const envName = `jshellArgsEnv${index}`;
envMap[envName] = arg;
return `$${envName}`;
});
return { envMap, finalArgs };
}

const notebookChangeProjectContextHandler = async (ctx: INotebookToolbar) => {
try {
const uri: Uri = ctx.notebookEditor.notebookUri;
Expand Down