Skip to content

Feature/2314 save playlist and regions in screen manager #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 23, 2024
Merged

Feature/2314 save playlist and regions in screen manager #259

merged 22 commits into from
Oct 23, 2024

Conversation

@sinejespersen
Copy link
Contributor

@sinejespersen sinejespersen commented Sep 26, 2024 •
edited
Loading

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2314

Description

Related to: os2display/display-api-service#213

  • Clean up screen-manager.jsx
  • Add saving of playlists/groups with screen (as opposed to after)
  • Change bootstrap column class from col-md-8 -> col-md-12 (see image below)
  • Update api.generated.ts to match related pr
  • Fix a small console errer to do with key in login.jsx
  • Add @rtk-incubator/rtk-query-codegen-openapi to package.json
  • Sort playlists based on weight in drag/drop component

Screenshot of the result

image

@sinejespersen sinejespersen mentioned this pull request Sep 26, 2024
Merged
@sinejespersen sinejespersen requested a review from tuj September 27, 2024 06:42
@tuj tuj added the bug Something isn't working label Sep 30, 2024
tuj
tuj previously approved these changes Sep 30, 2024
View reviewed changes
sinejespersen
sinejespersen commented Oct 7, 2024
View reviewed changes
src/app.scss
.loading-spinner {
margin-right: 1em;
}
.loading-spinner {
Copy link
Contributor Author

@sinejespersen sinejespersen Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-10-02 at 20 03 11

@sinejespersen sinejespersen requested a review from tuj October 9, 2024 09:06
tuj
tuj reviewed Oct 9, 2024
View reviewed changes
@sinejespersen sinejespersen requested a review from tuj October 16, 2024 10:05
tuj
tuj previously approved these changes Oct 21, 2024
View reviewed changes
Sine Jespersen added 19 commits October 23, 2024 11:38
2314: screen manager clean up and save groups and playlists with screen
8a3cfad
2314: col-md-8->col-md-12 to give space to grid generator
2a71308
2314: remove unused strings
b7f53d1
2314: changelog
3294420
2314: method to add empty playlist array to regions
b0de951
2314: fix css spinner
3be3cdf
2314: add regionIdForInitializeCallback prop
d207a33
2314: callback to add regions to formstateobject
afaee9b
2414: add key to login map to avoid console errors
5e4124c
2314: update api.json/api.generated.ts
12a8aed
2314: add @rtk-incubator/rtk-query-codegen-openapi to package.json
d330dbe
2314: add comments
ed4bec5
2314: update changelog
3422ca8
2314: more changelog
dc0e6d0
2314: Proptypes updated
539d5a0
2314: update mapgroups and remove check before mapping playlists
61a7714
2314: initialize selected groups
b5e2b63
2314: check if inScreenGroups exists on mapgroups
6e1d78b
2314: update changelog
00340c0
@sinejespersen sinejespersen force-pushed the feature/2314-save-playlist-and-regions-in-screen-manager branch from ac165be to f10897b Compare October 23, 2024 09:39
@sinejespersen sinejespersen requested a review from tuj October 23, 2024 09:45
@sinejespersen sinejespersen merged commit bf4f641 into develop Oct 23, 2024
4 checks passed
@sinejespersen sinejespersen deleted the feature/2314-save-playlist-and-regions-in-screen-manager branch October 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turegjorup turegjorup turegjorup approved these changes

@tuj tuj Awaiting requested review from tuj

Assignees

@sinejespersen sinejespersen

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sinejespersen @turegjorup @tuj