Skip to content

Feature/2314 save playlist and regions in screen processor #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Oct 23, 2024
Merged

Feature/2314 save playlist and regions in screen processor #213

merged 36 commits into from
Oct 23, 2024

Conversation

@sinejespersen
Copy link
Contributor

@sinejespersen sinejespersen commented Sep 26, 2024 •
edited
Loading

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2314

Description

Related to: os2display/display-admin-client#259

  • Set phpdoc_to_comment to falsein .php-cs-fixer.dist.php to avoid breaking psalm ignore
  • Add regions and groups to ScreenInput.php
  • Add "cascade: persist remove" to PlaylistScreenRegion
  • Save playlist/regions in ScreenProcessor.php (as an alternative to sending multiple requests)
  • Save groups in ScreenProcessor.php
  • Update psalm baseline
  • Add regions/playlists and groups to POST screen test
  • composer update symfony/* --with-dependencies

Screenshot of the result

N/A

@sinejespersen sinejespersen mentioned this pull request Sep 26, 2024
Merged
tuj
tuj requested changes Sep 30, 2024
View reviewed changes
turegjorup
turegjorup reviewed Sep 30, 2024
View reviewed changes
@jekuaitk jekuaitk mentioned this pull request Oct 9, 2024
Merged
Sine Jespersen added 24 commits October 9, 2024 11:04
2314: add regions and playlists in screen processor to avoid multiple…
6277d73 
… edits and deadlock
2314: add regionsAndPlaylists and groups to screeninput
aa9cd51
2314: add deleteAllRelationsForARegion, to delete screen playlists an…
3b9be3a 
…d before saving new
2314: add cascade: ['persist', 'remove'] to playlistScreenRegions on …
1231e39 
…screen
2314: delete playlists and save groups
591b8ec
2314: make psalm happy
74cb181
2314: psalm will never be happy
49fda45
2314: coding standards appyl
444d32c
2314: update changelog
0f863e1
2314: update baseline
2686840
2314: update changelog
24dc479
2314: update-api-spec
1cca81f
2314: delete playlists that is removed in frontend, save new playlists
0f39176
2314: handle playlist weight
1d0c374
2314: coding standards apply
55e921e
2314: markdown remove indentation for code sections
a9edd7b
2314: code analysis
ec37986
2314: update api spec
9267955
2314: composer update "symfony/*" --with-dependencies
2b7dbf4
2314: avoid deleting all groups and readding
da4e13e
2314: coding standards apply
a1f35fe
2314: test with todo
10d1308
2314: replace todo with screen id
2cfe1d3
2314: changelog
2ee824c
@sinejespersen sinejespersen force-pushed the feature/2314-save-playlist-and-regions-in-screen-processor branch from f4e4a0f to 2ee824c Compare October 9, 2024 09:05
tuj
tuj requested changes Oct 9, 2024
View reviewed changes
@sinejespersen sinejespersen requested a review from tuj October 22, 2024 11:31
@sinejespersen sinejespersen merged commit 0d667c7 into develop Oct 23, 2024
13 checks passed
@sinejespersen sinejespersen deleted the feature/2314-save-playlist-and-regions-in-screen-processor branch October 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@turegjorup turegjorup turegjorup approved these changes

@tuj tuj Awaiting requested review from tuj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sinejespersen @turegjorup @tuj