Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
6277d73
2314: add regions and playlists in screen processor to avoid multiple…
Sep 25, 2024
aa9cd51
2314: add regionsAndPlaylists and groups to screeninput
Sep 26, 2024
3b9be3a
2314: add deleteAllRelationsForARegion, to delete screen playlists an…
Sep 26, 2024
1231e39
2314: add cascade: ['persist', 'remove'] to playlistScreenRegions on …
Sep 26, 2024
591b8ec
2314: delete playlists and save groups
Sep 26, 2024
74cb181
2314: make psalm happy
Sep 26, 2024
49fda45
2314: psalm will never be happy
Sep 26, 2024
444d32c
2314: coding standards appyl
Sep 26, 2024
0f863e1
2314: update changelog
Sep 26, 2024
2686840
2314: update baseline
Sep 26, 2024
24dc479
2314: update changelog
Sep 26, 2024
1cca81f
2314: update-api-spec
Oct 1, 2024
0f39176
2314: delete playlists that is removed in frontend, save new playlists
Oct 7, 2024
1d0c374
2314: handle playlist weight
Oct 7, 2024
55e921e
2314: coding standards apply
Oct 7, 2024
a9edd7b
2314: markdown remove indentation for code sections
Oct 7, 2024
ec37986
2314: code analysis
Oct 7, 2024
9267955
2314: update api spec
Oct 7, 2024
2b7dbf4
2314: composer update "symfony/*" --with-dependencies
Oct 8, 2024
da4e13e
2314: avoid deleting all groups and readding
Oct 8, 2024
a1f35fe
2314: coding standards apply
Oct 8, 2024
10d1308
2314: test with todo
Oct 9, 2024
2cfe1d3
2314: replace todo with screen id
Oct 9, 2024
2ee824c
2314: changelog
Oct 9, 2024
863cc43
2314: update changelog
Oct 9, 2024
cb6970c
2314: remove annotation used locally
Oct 9, 2024
9c327c1
2314: fixes from comment on pr
Oct 9, 2024
5c6ccf2
2314: add handling of changed weight
Oct 10, 2024
c98d07a
2314: comment on pr, move function to entity instead of processor
Oct 16, 2024
0947605
2314: update changed variable name
Oct 16, 2024
7a2f1e7
2314: wrap changelog
Oct 16, 2024
3861ee8
2314: supress psalm InvalidArgument
Oct 22, 2024
2daf652
2314: screen processor lint
Oct 22, 2024
22e8cd9
2314: lint broke psalm, readd psalm
Oct 22, 2024
c5a33ab
2314: add phpdoc_to_comment false to php-cs-fixer
Oct 22, 2024
b2f4849
2314: update changelog
Oct 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
'phpdoc_align' => false,
'no_superfluous_phpdoc_tags' => false,
'array_syntax' => ['syntax' => 'short'],
'phpdoc_to_comment' => false,
'declare_strict_types' => true,
ConstructorEmptyBracesFixer::name() => true,
MultilinePromotedPropertiesFixer::name() => true,
Expand Down
44 changes: 26 additions & 18 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ All notable changes to this project will be documented in this file.

- [#214](https://github.com/os2display/display-api-service/pull/214)
- Updated endSessionUrl to be nullable.

- [#213](https://github.com/os2display/display-api-service/pull/213)
- Set `phpdoc_to_comment` to `false`in `.php-cs-fixer.dist.php` to avoid breaking psalm ignore
- Add regions and groups to `ScreenInput.php`
- Add "cascade: persist remove" to PlaylistScreenRegion
- Save playlist/regions in `ScreenProcessor.php` and in `src/entity/ScreenLayoutRegions` (as an alternative to sending
multiple requests)
- Save groups in `ScreenProcessor.php` and in `src/entity/tenant/Screen.php`
- Update psalm baseline
- Add regions/playlists and groups to POST screen test
- `composer update symfony/* --with-dependencies`

- [#193](https://github.com/os2display/display-api-service/pull/193)
- Adds support for interactive slides.
- Adds interactivity for creating quick bookings from a slide through Microsoft Graph.
Expand Down Expand Up @@ -62,8 +74,8 @@ All notable changes to this project will be documented in this file.
- Changed route prefix to v2.
- [#197](https://github.com/os2display/display-api-service/pull/197)
- Fixed weight issue when assigning slides to playlist.
- [#194](https://github.com/os2display/display-api-service/pull/194)
Updated test run documentation and added test for `rrule` in playlist.
- [#194](https://github.com/os2display/display-api-service/pull/194) Updated test run documentation and added test for
`rrule` in playlist.
- Fixed issue with PlaylistSlide transaction.
- Fixed issues with feed following api platform upgrade.
- [#192](https://github.com/os2display/display-api-service/pull/192)
Expand All @@ -85,8 +97,8 @@ All notable changes to this project will be documented in this file.
- [#184](https://github.com/os2display/display-api-service/pull/184)
- Added RelationsModifiedTrait to serialization groups.
- [#182](https://github.com/os2display/display-api-service/pull/182)
- Changed "Theme" api output to have "Logo" embedded to avoid 404 errors when fetching logo from other shared slide
w. foreign tenant.
- Changed "Theme" api output to have "Logo" embedded to avoid 404 errors when fetching logo from other shared slide w.
foreign tenant.
- [#181](https://github.com/os2display/display-api-service/pull/181)
- Update minimum PHP version to 8.2 to support trait constants
- Add 'relationsModified' timestamps on relevant entities and API resources.
Expand All @@ -107,16 +119,11 @@ All notable changes to this project will be documented in this file.
- Switch from doctrine annotations to attributes
- Add rector as dev dependency and apply rules
- Handle doctrine deprecations
- [#173](https://github.com/os2display/display-api-service/pull/173)
Upgraded to API Platform 3
- [#172](https://github.com/os2display/display-api-service/pull/172)
Linted YAML API resources
- [#171](https://github.com/os2display/display-api-service/pull/171)
Fixed slide playlists collection operation.
- [#170](https://github.com/os2display/display-api-service/pull/170)
Updated Symfony development packages.
- [#165](https://github.com/os2display/display-api-service/pull/165)
Symfony 6.3
- [#173](https://github.com/os2display/display-api-service/pull/173) Upgraded to API Platform 3
- [#172](https://github.com/os2display/display-api-service/pull/172) Linted YAML API resources
- [#171](https://github.com/os2display/display-api-service/pull/171) Fixed slide playlists collection operation.
- [#170](https://github.com/os2display/display-api-service/pull/170) Updated Symfony development packages.
- [#165](https://github.com/os2display/display-api-service/pull/165) Symfony 6.3
- [#162](https://github.com/os2display/display-api-service/pull/162)
- Adds "external" openid-connect provider.
- Renamed "oidc" openid-connect provider to "internal".
Expand All @@ -126,9 +133,9 @@ All notable changes to this project will be documented in this file.
- Upgrades openid-connect bundle to 3.1 to support multiple providers.
- Changes php requirement in composer.json to >= 8.1.
- Removed PHP Upgrade coding standards github actions check.
- Changed user identifier from email to providerId. Made email nullable. Copied value from email to providerId in migration.
- [#161](https://github.com/os2display/display-api-service/pull/161)
Fixed non-entity related psalm errors.
- Changed user identifier from email to providerId. Made email nullable. Copied value from email to providerId in
migration.
- [#161](https://github.com/os2display/display-api-service/pull/161) Fixed non-entity related psalm errors.

## [1.5.0] - 2023-10-26

Expand Down Expand Up @@ -205,7 +212,8 @@ All notable changes to this project will be documented in this file.
- [#138](https://github.com/os2display/display-api-service/pull/138)
- Fixed Tenant and command to allow for empty fallbackImageUrl.
- [#139](https://github.com/os2display/display-api-service/pull/139)
- Changed from service decoration to event listeners to re-enable setting `tenants` on the response from `/v1/authentication/token`.
- Changed from service decoration to event listeners to re-enable setting `tenants` on the response from
`/v1/authentication/token`.
- Ensure same response data from both `/v1/authentication/token` and `/v1/authentication/token/refresh`endpoints.
- Added `user` and `tenants` to JWT payload.

Expand Down
31 changes: 16 additions & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,16 +258,16 @@ the coding standard for the project.

- PHP files [PHP Coding Standards Fixer](https://cs.symfony.com/)

```shell
docker compose exec phpfpm composer coding-standards-check
```
```shell
docker compose exec phpfpm composer coding-standards-check
```

- Markdown files (markdownlint standard rules)

```shell
docker run --rm -v .:/app --workdir=/app node:20 npm install
docker run --rm -v .:/app --workdir=/app node:20 npm run coding-standards-check
```
```shell
docker run --rm -v .:/app --workdir=/app node:20 npm install
docker run --rm -v .:/app --workdir=/app node:20 npm run coding-standards-check
```

#### YAML

Expand All @@ -281,23 +281,24 @@ To attempt to automatically fix coding style issues

- PHP files [PHP Coding Standards Fixer](https://cs.symfony.com/)

```sh
docker compose exec phpfpm composer coding-standards-apply
```
```sh
docker compose exec phpfpm composer coding-standards-apply
```

- Markdown files (markdownlint standard rules)

```shell
docker run --rm -v .:/app --workdir=/app node:18 npm install
docker run --rm -v .:/app --workdir=/app node:18 npm run coding-standards-apply
```
```shell
docker run --rm -v .:/app --workdir=/app node:18 npm install
docker run --rm -v .:/app --workdir=/app node:18 npm run coding-standards-apply
```

## Tests

Run automated tests:

```shell
docker compose exec phpfpm composer tests
docker compose exec phpfpm composer test setup
docker compose exec phpfpm composer test
```

Disable or hide deprecation warnings using the [`SYMFONY_DEPRECATIONS_HELPER` environment
Expand Down
Loading