Check flat node file format for forwards compatibility #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a flat node file the first location is that of node id 0, which does not exist. So the first location must always be the undefined location, otherwise we might be looking at a different kind of file. This adds a check for forwards compatibility. If and when we change the file format, we can use the first 8 bytes to differentiate the file formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a flat node file the first location is that of node id 0, which does not exist. So the first location must always be the undefined location, otherwise we might be looking at a different kind of file.
This adds a check for forwards compatibility. If and when we change the file format, we can use the first 8 bytes to differentiate the file formats.