Skip to content

Check flat node file format for forwards compatibility #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Check flat node file format for forwards compatibility #2279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/node-persistent-cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ node_persistent_cache::node_persistent_cache(std::string file_name,
}

m_index = std::make_unique<index_t>(m_fd);

// First location must always be the undefined location, otherwise we
// might be looking at a different kind of file. This check here is for
// forwards compatibility. If and when we change the file format, we
// can use the first 8 bytes to differentiate the file format.
auto const loc = get(0);
if (loc.is_defined()) {
throw fmt_error("Not a version 1 flatnode file '{}'", m_file_name);
}
}

node_persistent_cache::~node_persistent_cache() noexcept
Expand Down
Loading