Simplify and fix code getting relation members #2365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way we are getting node members of relations. We now always get the locations of those nodes directly in the middle code instead of only getting the nodes themselves and adding the locations through an extra call from the output. This also fixes a problem where node locations for untagged nodes were not retrieved from the RAM middle. The node_get() code does that correctly, while the old code didn't.
Collaborator
|
This will make the code quite a bit slower when "store nodes" is enabled together with flatnode stiore. Before the change it would just go to the flatnode store to load the locations, now it will send a separate DB query for every single node. |
Collaborator
Author
|
Closing in favour of #2367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way we are getting node members of relations. We now always get the locations of those nodes directly in the middle code instead of only getting the nodes themselves and adding the locations through an extra call from the output.
This also fixes a problem where node locations for untagged nodes were not retrieved from the RAM middle. The node_get() code does that correctly, while the old code didn't.