Fix problem when detecting PostGIS version #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Aug 18, 2025
src/pgsql-capabilities.cpp
Outdated
| if (res.num_tuples() >= 2) { | ||
| capabilities().postgis = {std::stoi(std::string{res.get(0, 0)}), | ||
| std::stoi(std::string{res.get(1, 0)})}; | ||
| return; |
Collaborator
There was a problem hiding this comment.
Does this return do something?
Collaborator
Author
There was a problem hiding this comment.
Sorry. Leftover from an earlier version. Fixed and new version force-pushed.
We are accessing data that doesn't exist if we don't get three rows from the SQL query. If the PostGIS version could not be detected, we report that.
joto
force-pushed
the
fix-postgis-check
branch
from
8d4b632 to
79bc89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are accessing data that doesn't exist if we don't get three rows from the SQL query.
If the PostGIS version could not be detected, we report that.
Fixes #2378