Skip to content

Fix problem when detecting PostGIS version #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Fix problem when detecting PostGIS version #2379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/pgsql-capabilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,15 @@ void init_postgis_version(pg_conn_t const &db_connection)
capabilities().database_name);
}

capabilities().postgis = {std::stoi(std::string{res.get(0, 0)}),
std::stoi(std::string{res.get(1, 0)})};
try {
if (res.num_tuples() >= 2) {
capabilities().postgis = {std::stoi(std::string{res.get(0, 0)}),
std::stoi(std::string{res.get(1, 0)})};
}
} catch (...) {
// Fall through if std::stoi() fails in which case the version
// is reported as 0.
}
}

} // anonymous namespace
Expand All @@ -114,8 +121,13 @@ void init_database_capabilities(pg_conn_t const &db_connection)
try {
log_info("Database version: {}",
capabilities().settings.at("server_version"));
log_info("PostGIS version: {}.{}", capabilities().postgis.major,
capabilities().postgis.minor);

if (capabilities().postgis.major == 0) {
log_info("PostGIS version: could not be detected");
} else {
log_info("PostGIS version: {}.{}", capabilities().postgis.major,
capabilities().postgis.minor);
}

auto const version_str =
capabilities().settings.at("server_version_num");
Expand Down
Loading