fix: continue pruning if version is not found#48
Closed
PaddyMc wants to merge 1 commit intoosmo-v29/1.2.4from
Closed
fix: continue pruning if version is not found#48PaddyMc wants to merge 1 commit intoosmo-v29/1.2.4from
PaddyMc wants to merge 1 commit intoosmo-v29/1.2.4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When pruning cannot prune a version of the store it gets stuck. This PR moves onto the next version in the store if pruning returns a not found error.
Checking broken stores
Use this PR and run:
osmosis-labs/cosmprund#2
Things we don't know
Why are there states deleted outside of pruning? Why does this become more apparent with async pruning?
Another version of the fix
cosmos#1048
This fix, works in the same way and just continues after the is a version not found error
Why this is needed
Currently if pruning breaks with this error the chain state will start to grow quickly.
What the fix will look like
Osmosis mainnet with broken state:
Before this would have and the state would bloat
This is osmosis testnet with broken state
This represents a large backlog as pruning is on
720388727208281