Skip to content

fix: continue pruning if version is not found #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PaddyMc wants to merge 1 commit into from
Closed

fix: continue pruning if version is not found #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions nodedb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,8 @@ func (ndb *nodeDB) startPruning() {
}

if err := ndb.deleteVersionsTo(toVersion); err != nil {
ndb.logger.Error("Error while pruning", "err", err)
time.Sleep(1 * time.Second)
ndb.logger.Error("Error while pruning full store asynchronously", "version to prune to", toVersion, "err", err)
time.Sleep(500 * time.Millisecond)
continue
}

Expand Down Expand Up @@ -711,7 +711,12 @@ func (ndb *nodeDB) deleteVersionsTo(toVersion int64) error {
rootkeyCache := &rootkeyCache{}
for version := first; version <= toVersion; version++ {
if err := ndb.deleteVersion(version, rootkeyCache); err != nil {
return err
// If the version is not found in the store continue on to the next version available
if err != ErrVersionDoesNotExist {
return err
}

ndb.logger.Error("Error while pruning, moving on the the next version in the store", "version missing", version, "next version", version+1, "err", err)
}
ndb.resetFirstVersion(version + 1)
}
Expand Down