Change DART key to point to packages.osrfoundation.org 6.16#21
Change DART key to point to packages.osrfoundation.org 6.16#21
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
gz/gazebo.yaml
Outdated
| ubuntu: [libdart-dev] | ||
| DART: # only from packages.osrfoundation.org | ||
| ubuntu: [libdart6.13-dev] | ||
| DART-6.16: # only from packages.osrfoundation.org |
There was a problem hiding this comment.
Do we want a separate one for 6.16?
There was a problem hiding this comment.
If we are going to support at the same time some collections with 6.13 and some with 6.16 we need to define both.
There was a problem hiding this comment.
I was hoping we didn't have to support both. This would now require us having to maintain a different entry in package.xml for 6.13 and 6.16 in gz-physics. We'd also need to update our gz_vendor scripts to handle DART-6.16
There was a problem hiding this comment.
According to the plan in gazebosim/gz-physics#816 the transition proposed is to first do in gz-physics9 (Jetty) and do the rest step by step. We can go here with leaving the DART to point to 6.16 from the beginning now (omitting 6.13) that will bring the new physics for everything that is using this repository.
I think that it is fine to avoid the changes in package.xml, does not fully reflect what is in the Debians but seems like a good tradeoff.
| DART: | ||
| ubuntu: [libdart-dev] | ||
| DART: # only from packages.osrfoundation.org | ||
| ubuntu: [libdart6.16-dev] |
There was a problem hiding this comment.
I think we need libdart6.16-dev-all actually because we also need -utils-urdf-dev, -collision-bullet-dev, and -collision-ode-dev. See https://github.com/gazebosim/gz-physics/blob/a1e7ae5aa7938ab24bcddc8da96621a4a07ced89/.github/ci/packages.apt#L2-L7
The current setup of this repository to resolve DART key to the default in Ubuntu is broken https://build.osrfoundation.org/job/ci__colcon_any-manual_ubuntu_noble_amd64/61/console.
Doing a breaking change here since I think that there is no option for previous users of this osrf-rosdep to get the DART right for Gazebo so I'm defaulting to 6.13 and consider a bug-fix and not a feature change.
Added the DART-6.16 to resolve to the upcoming new package.