Handle in-browser translations more gracefully #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Chrome is presented with a natural language, it can offer to translate the HTML page. Unfortunately, this caused labs to fail. This commit modifies to code to work around this, so that after translation the lab continues to work. The explanation about the lab is translated. Unfortunately, this does *not* translate the responses shown via alert boxes (e.g., hints and congrats). However, since the lab now *works*, users can copy that text into something to do a translation. This commit makes the labs much more accessible to those who speak natural languages we don't currently have translations for. Signed-off-by: David A. Wheeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Chrome is presented with a natural language, it can offer to translate the HTML page. Unfortunately, this caused labs to fail.
This commit modifies to code to work around this, so that after translation the lab continues to work.
The explanation about the lab is translated.
Unfortunately, this does not translate the responses shown via alert boxes (e.g., hints and congrats).
However, since the lab now works, users can copy that text into something to do a translation.
This commit makes the labs much more accessible to those who speak natural languages we don't currently have translations for.