Skip to content

Handle in-browser translations more gracefully #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Handle in-browser translations more gracefully #766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions docs/labs/checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,15 @@ const attemptIdPattern = /^attempt(\d+)$/;

/*
* Given Node @form in document, return array of indexes of input/textareas
* The values retrieved are *input* field indexes (`inputIndexes`),
* starting at 0 for the first user input.
*
* Note: At one time we ran this calculation when a user pressed
* a button. However, if you *translate* the page using Chrome's translator,
* that will cause this routine to fail because querySelectorAll will fail.
* To work around this,
* it's better to calculate all of these values on page load and store it
* (e.g., as dataset.inputIndexes values on the buttons).
*/
function findIndexes(form) {
try {
Expand All @@ -364,7 +373,8 @@ function findIndexes(form) {
}
}
// alert(`findIndexes = ${result}`);
return result;
// Return as JSON string so it's easily stored, etc.
return JSON.stringify(result);
}
} catch (e) {
showDebugOutput(
Expand Down Expand Up @@ -499,13 +509,16 @@ function showHint(e) {
} else if (!hints) {
alert(t('no_hints'));
} else {
let validIndexes = findIndexes(e.target.form);
// Use *precalculated* input field indexes to work around
// problem in Chrome translator.
let validIndexes = e.target.dataset.inputIndexes;
alert(findHint(attempt, validIndexes));
}
}

function showAnswer(e) {
let formIndexes = findIndexes(e.target.form); // Indexes in this form
// Get indexes in *this* form.
let formIndexes = JSON.parse(e.target.dataset.inputIndexes);
let goodAnswer = formIndexes.map(i => expected[i]).join('\n\n');
if (!user_solved) {
user_gave_up = true;
Expand Down Expand Up @@ -819,6 +832,8 @@ function initPage() {
}
for (let hintButton of document.querySelectorAll("button.hintButton")) {
hintButton.addEventListener('click', (e) => { showHint(e); });
// Presumes button's parent is the form
hintButton.dataset.inputIndexes = findIndexes(hintButton.parentNode);
if (!hintButton.title) {
hintButton.title = t('hint_title');
}
Expand All @@ -831,6 +846,8 @@ function initPage() {
}
for (let giveUpButton of document.querySelectorAll("button.giveUpButton")) {
giveUpButton.addEventListener('click', (e) => { maybeShowAnswer(e); });
// Presumes button's parent is the form
giveUpButton.dataset.inputIndexes = findIndexes(giveUpButton.parentNode);
if (!giveUpButton.title) {
giveUpButton.title = t('give_up_title');
}
Expand Down