Conversation
|
Is release the right target for this PR? |
* feat: migrate from pylint/black to ruff
ahmed-arb
left a comment
There was a problem hiding this comment.
LGTM. I just have a few questions
| ( | ||
| mfe, | ||
| "footer_slot", | ||
| "org.openedx.frontend.layout.footer.v1", |
There was a problem hiding this comment.
Is there a reason for changing the alias to its slot ID?
There was a problem hiding this comment.
I think we should move from the legacy alias footer_slot to the canonical, versioned plugin slot ID org.openedx.frontend.layout.footer.v1. The alias still works for backward compatibility, but using the fully qualified slot ID aligns with current OpenEdx conventions and helps keep the code forward-compatible.
ahmed-arb
left a comment
There was a problem hiding this comment.
Looks good. Just change the base branch to main.
This reverts commit f090b4e.
|
This PR broke our own customizations of footer that we used to add on top of tutor-indigo, which we do through a tutor plugin: |
|
This is being discussed in this discuss thread: https://discuss.openedx.org/t/footer-slot-broken-in-ulmo/18329/6 |
Hey @mboisson, And regarding the issue(i.e. overriding the indigo footer) you guys are facing, I had some capacity today to look into it. Can you guys try using We are open to discussion if you face any further errors. |
|
We ended up removing If I had to recommend something though, it would be to make sure that the "priority" actually work, i.e. operations with higher priority are applied after operations with lower priority. |
It's an upstream issue as priorities for plugin slots are not handled in tutor-indigo plugin. May be you can create one in openedx/frontend-plugin-framework repository to confirm if there is some bug. |
Add support to override indigo footer using plugin slot. Related conversation: #181 (comment).
Add support to override indigo footer using plugin slot. Related conversation: #181 (comment).
|
Hey @mboisson, Let me Explain it a bit, So, we can close this issue: openedx/frontend-plugin-framework#121 |
I see... so there's no way to hide something that has been added by another plugin ? (i.e. to replace it) ? |
Actually there is, that I have suggested above(Link). We are also adding this patch by default in tutor-indigo(PR) So that if someone wants to override the footer, they can do it while keeping the indigo plugin enabled. |
Add support to override indigo footer using plugin slot. Related conversation: #181 (comment).


Deprecate Indigo footer package #144