-
Notifications
You must be signed in to change notification settings - Fork 431
feat: deprecate indigo footer #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cf48e29
feat: v20.0.1 release (#176)
DawoudSheraz 953e744
feat: deprecate indigo footer
HammadYousaf01 f20e8ef
feat: migrate from pylint/black to ruff (#180)
HammadYousaf01 0616922
Merge branch 'release' into hammad/deprecate-indigo-footer
HammadYousaf01 20f5295
fix: resolve comments
HammadYousaf01 fa9ad2c
Merge branch 'main' into hammad/deprecate-indigo-footer
HammadYousaf01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
changelog.d/20250703_181956_danyal.faheem_ora_grading_dark_theme_issue.md
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
....d/20250819_191723_136305115+HammadYousaf01_tutor_indigo_accessibility_fixes.md
This file was deleted.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
changelog.d/20251028_185649_136305115+HammadYousaf01_ruff_migration.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - [Improvement] Migrate from pylint and black to ruff. (by @HammadYousaf01) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "20.0.0" | ||
| __version__ = "20.0.1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| if (typeof useIntl === "undefined") { | ||
| const intl = await import("@edx/frontend-platform/i18n"); | ||
| globalThis.useIntl = intl.useIntl; | ||
| } | ||
|
|
||
| const IndigoFooter = () => { | ||
| const intl = useIntl(); | ||
| const config = getConfig(); | ||
|
|
||
| const indigoFooterNavLinks = config.INDIGO_FOOTER_NAV_LINKS || []; | ||
|
|
||
| const messages = { | ||
| "footer.poweredby.text": { | ||
| id: "footer.poweredby.text", | ||
| defaultMessage: "Powered by", | ||
| description: "text for the footer", | ||
| }, | ||
| "footer.tutorlogo.altText": { | ||
| id: "footer.tutorlogo.altText", | ||
| defaultMessage: "Runs on Tutor", | ||
| description: "alt text for the footer tutor logo", | ||
| }, | ||
| "footer.logo.altText": { | ||
| id: "footer.logo.altText", | ||
| defaultMessage: "Powered by Open edX", | ||
| description: "alt text for the footer logo.", | ||
| }, | ||
| "footer.copyright.text": { | ||
| id: "footer.copyright.text", | ||
| defaultMessage: `Copyrights ©${new Date().getFullYear()}. All Rights Reserved.`, | ||
| description: "copyright text for the footer", | ||
| }, | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="wrapper wrapper-footer"> | ||
| <footer id="footer" className="tutor-container"> | ||
| <div className="footer-top"> | ||
| <div className="powered-area"> | ||
| <ul className="logo-list"> | ||
| <li>{intl.formatMessage(messages["footer.poweredby.text"])}</li> | ||
| <li> | ||
| <a | ||
| href="https://edly.io/tutor/" | ||
| rel="noreferrer" | ||
| target="_blank" | ||
| ></a> | ||
| <img | ||
| src={`${config.LMS_BASE_URL}/theming/asset/images/tutor-logo.png`} | ||
| alt={intl.formatMessage(messages["footer.tutorlogo.altText"])} | ||
| width="57" | ||
| /> | ||
| </li> | ||
| <li> | ||
| <a href="https://open.edx.org" rel="noreferrer" target="_blank"> | ||
| <img | ||
| src={`${config.LMS_BASE_URL}/theming/asset/images/openedx-logo.png`} | ||
| alt={intl.formatMessage(messages["footer.logo.altText"])} | ||
| width="79" | ||
| /> | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <nav className="nav-colophon"> | ||
| <ol> | ||
| {indigoFooterNavLinks.map((link) => ( | ||
| <li key={link.url}> | ||
| <a href={`${config.LMS_BASE_URL}${link.url}`}>{link.title}</a> | ||
| </li> | ||
| ))} | ||
| </ol> | ||
| </nav> | ||
| </div> | ||
| <span className="copyright-site"> | ||
| {intl.formatMessage(messages["footer.copyright.text"])} | ||
| </span> | ||
| </footer> | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for changing the alias to its slot ID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move from the legacy alias
footer_slotto the canonical, versioned plugin slot IDorg.openedx.frontend.layout.footer.v1. The alias still works for backward compatibility, but using the fully qualified slot ID aligns with current OpenEdx conventions and helps keep the code forward-compatible.