Skip to content

fix(account-creation): fix crash in settings page #20650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+4 −7
Merged

fix(account-creation): fix crash in settings page #20650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/manager/apps/account-creation/src/pages/settings/settings.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export default function Settings() {
isDisabled={!languages?.length}
onOdsChange={onChange}
onBlur={onBlur}
key={`languages_for_${selectedCountry}`}
key={`languages_for_${selectedCountry}_${selectedCurrency}`}
hasError={Boolean(languages?.length && errors[name])}
data-testid="language-select"
>
Expand Down
8 changes: 3 additions & 5 deletions packages/manager/apps/account-creation/src/pages/settings/settings.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,8 @@ describe('SettingsPage', () => {
await setInputhValue(currencySelectElement, 'EUR');
});

const languageSelectElement = screen.getByTestId('language-select');

await waitFor(() => {
const languageSelectElement = screen.getByTestId('language-select');
expect(languageSelectElement.getAttribute('is-disabled')).not.toBe(
'true',
);
Expand All @@ -134,10 +133,9 @@ describe('SettingsPage', () => {
await setInputhValue(countryComboboxElement, 'GB');
});

const currencySelectElement = screen.getByTestId('currency-select');
const languageSelectElement = screen.getByTestId('language-select');

await waitFor(() => {
const currencySelectElement = screen.getByTestId('currency-select');
const languageSelectElement = screen.getByTestId('language-select');
expect(currencySelectElement.getAttribute('value')).toBe('GBP');
expect(languageSelectElement.getAttribute('value')).toBe('en-GB');
});
Expand Down
1 change: 0 additions & 1 deletion packages/manager/apps/account-creation/src/routes/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default (
Component={LayoutPage}
errorElement={
<ErrorBoundary
isPreloaderHide
isRouteShellSync
redirectionApp="account-creation"
/>
Expand Down
Loading