fix(account-creation): fix crash in settings page #20650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achrafHafedh
force-pushed
the
fix/MANAGER-20305
branch
from
62484e7 to
f315202
Compare
JacquesLarique
requested changes
Nov 27, 2025
Contributor
JacquesLarique
left a comment
JacquesLarique
left a comment
There was a problem hiding this comment.
Can you remove the isPreloaderHide prop on the ErrorBoundary component in packages/manager/apps/account-creation/src/routes/routes.tsx please
ref: #MANAGER-20305 Signed-off-by: achraf hafedh <[email protected]>
achrafHafedh
force-pushed
the
fix/MANAGER-20305
branch
from
e7b845a to
3f4bb2d
Compare
JacquesLarique
approved these changes
Nov 27, 2025
MehdiZaghouani
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-20305
Description
Ticket Reference: #MANAGER-20305
Additional Information