Skip to content

Conversation

@jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Oct 8, 2025

The update test executed in GitHub actions has some flaky executions. In order to make it more robust and deterministic, some changes were done in the workflow:

  • Adding -no-snapshot to the emulator options: That options will assure that no leftovers from other executions affect to the current one. It will work together with the force-avd-creation parameter.
  • Switching auto for on in the -accel parameter: if hardware acceleration is available, it will be used making the test more robust. If not available, test will fail. GitHub actions' runners have the option available, so, we can assume that "con"
  • Increasing memory assigned to the emulator, so, it will be less likely to hang (from 2048 to 4096 MB)
  • Added --no-daemon to gradlew command. That should not affect because there is only one gradlew command, but in the local executions could make the execution more performant.

In addition, added dependabot/* to the on: section, so the test will be executed in PRs opened by dependabot.

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec added this to the 4.7 - Current milestone Oct 8, 2025
@jesmrec jesmrec force-pushed the fix/improve_performance_emulator_actions branch from b1bf538 to 4028062 Compare October 8, 2025 11:27
@jesmrec jesmrec marked this pull request as ready for review October 8, 2025 11:43
@jesmrec jesmrec requested a review from joragua October 8, 2025 11:44
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, @jesmrec!

@jesmrec jesmrec force-pushed the fix/improve_performance_emulator_actions branch from ac08479 to 6a233e6 Compare October 8, 2025 15:39
@jesmrec jesmrec requested a review from joragua October 8, 2025 15:49
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jesmrec jesmrec merged commit 9fa4419 into master Oct 8, 2025
11 checks passed
@jesmrec jesmrec deleted the fix/improve_performance_emulator_actions branch October 8, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants