Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Nov 11, 2025

Related Issues

App: #4711

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

QA checks:

Reports:

@joragua joragua self-assigned this Nov 11, 2025
@joragua joragua linked an issue Nov 11, 2025 that may be closed by this pull request
10 tasks
@joragua joragua marked this pull request as ready for review November 11, 2025 12:25
@joragua joragua requested a review from jesmrec November 11, 2025 12:25
@joragua joragua force-pushed the feature/show_or_hide_disabled_spaces branch from 9da8e1a to 270920b Compare November 11, 2025 14:01
@joragua joragua requested a review from jesmrec November 11, 2025 14:06
Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Moving to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 11, 2025

QA checks

User with three spaces, and three different roles: manager, editor and viewer

Space 1: manager
Space 2: editor
Space 3: viewer

Setting disabled Setting enabled
all enabled all visible all visible
1 enabled
2, 3 disabled
1 visible
1 visible
2 enabled
1, 3 disabled
2 visible
1, 2 visible
3 enabled
1, 2 disabled
3 visible
1, 3 visible
1, 2 enabled
3 disabled
1, 2 visible
1, 2 visible
1, 3 enabled
2 disabled
1, 3 visible
1, 3 visible
2, 3 enabled
1 disabled
2, 3 visible
1, 2, 3 visible
all disabled all hidden
1 visible

Checked with spaces view, folder picker (copy and share with oC)

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 11, 2025

(1) [FIXED]

  1. Setting show disabled spaces is off
  2. Open the space list (not empty)
  3. Disable all listed spaces

Current:

Blank view

Expected:

placeholder that shows No spaces in the list

Xiaomi Redmi 13 Note
Android 15
c014d022a

@joragua
Copy link
Collaborator Author

joragua commented Nov 11, 2025

(1) should be fixed with the last commit 😄

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 11, 2025

Approved 🚀. Closer to 4.7

@jesmrec jesmrec merged commit 28a8089 into master Nov 12, 2025
10 checks passed
@jesmrec jesmrec deleted the feature/show_or_hide_disabled_spaces branch November 12, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Show/hide disabled spaces

4 participants