chore(vscode): second language server connection for oxfmt
#15837
+579
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
df6d604 to
cc0ec55
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
0a8f773 to
99701c2
Compare
graphite-app
bot
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
2 times, most recently
from
56be34f to
f7ff45d
Compare
graphite-app
bot
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
96a9a86 to
d5ec71f
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
f7ff45d to
240f96d
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
d5ec71f to
1ec9472
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
240f96d to
e919504
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
1ec9472 to
cce5a20
Compare
Sysix
changed the base branch from
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
to
graphite-base/15837
Sysix
force-pushed
the
graphite-base/15837
branch
from
e919504 to
784a33c
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
cce5a20 to
0fa8b4c
Compare
Sysix
changed the base branch from
graphite-base/15837
to
11-18-refacor_vscode_run_js_language_server_with_node_
Sysix
changed the base branch from
11-18-refacor_vscode_run_js_language_server_with_node_
to
graphite-base/15837
graphite-app
bot
force-pushed
the
graphite-base/15837
branch
from
784a33c to
0146b4c
Compare
graphite-app
bot
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
0fa8b4c to
35a58e9
Compare
graphite-app
bot
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
35a58e9 to
f61e18a
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
f61e18a to
f535ff0
Compare
Sysix
changed the base branch from
graphite-base/15837
to
11-21-refactor_vscode_add_lsp_helper_runexecutable_
This was referenced Nov 21, 2025
Sysix
changed the base branch from
11-21-refactor_vscode_add_lsp_helper_runexecutable_
to
graphite-base/15837
Sysix
force-pushed
the
11-24-refactor_vscode_move_restart_toggle_lsp_server_to_linter.ts_
branch
from
410b208 to
21d8200
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
2 times, most recently
from
4c41ce7 to
b61c6ca
Compare
Sysix
force-pushed
the
11-24-refactor_vscode_move_restart_toggle_lsp_server_to_linter.ts_
branch
from
21d8200 to
ca939c5
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
b61c6ca to
fbd1f92
Compare
Sysix
force-pushed
the
11-24-refactor_vscode_move_restart_toggle_lsp_server_to_linter.ts_
branch
from
ca939c5 to
5a29274
Compare
graphite-app
bot
changed the base branch from
11-24-refactor_vscode_move_restart_toggle_lsp_server_to_linter.ts_
to
graphite-base/15837
graphite-app
bot
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
fbd1f92 to
4244c81
Compare
graphite-app
bot
force-pushed
the
graphite-base/15837
branch
from
5a29274 to
62fb4c4
Compare
graphite-app
bot
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
4244c81 to
fbeed3f
Compare
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
3 times, most recently
from
4e615b4 to
3abbc36
Compare
Copilot finished reviewing on behalf of
Sysix
November 25, 2025 15:08
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
2 times, most recently
from
0932a4b to
eef3fe2
Compare
leaysgur
reviewed
Nov 26, 2025
Sysix
force-pushed
the
11-17-chore_vscode_second_language_server_connection_for_oxfmt_
branch
from
eef3fe2 to
ac599cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a second language server connection only for
oxfmt. Currently, it still uses the shippedoxc_language_serverbinary for formatting. When defining a customoxc.path.oxlint(oroxc.path.server), it will start the search process fornode_modules/.bin/oxfmtor usesoxc.path.oxfmt.This should be not a breaking change. When
node_modules/.bin/oxfmtshould be required for formatting, theConfigService.useOxcLanguageServerForFormattingmust not be modified. I would love to wait for the correct search implementation for.node_modules/.bin/oxlintbefore breaking the server detection (and probably removing the shipped server too).Default / with
oxfmtinstalled:Using the internal language server (once)
with
oxc.path.oxlint:Using the oxlint path server for linting.
Searching for
oxfmtinsidenode_modules/.binwith
oxc.path.fmt:Using the internal language server for linting.
Using
oxc.path.fmtbinary