-
-
Notifications
You must be signed in to change notification settings - Fork 724
test(vscode): testsetup for oxfmt --lsp server
#15883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(vscode): testsetup for oxfmt --lsp server
#15883
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
08c84f2 to
0c703c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test setup for the oxfmt --lsp server by creating a new test configuration that runs with the oxfmt LSP server instead of the main language server or oxlint server. The changes enable proper test isolation so that linter-specific tests can be skipped when testing the formatter-only server.
Key Changes:
- New test configuration in
.vscode-test.mjsfor oxfmt --lsp tests withSKIP_LINTER_TESTenvironment variable - Build scripts added for oxfmt in package.json and CI workflow
- Test suites conditionally skip based on
SKIP_LINTER_TESTto avoid running linter tests against the formatter-only server
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/.vscode-test.mjs | Adds new oxfmt --lsp test configuration that sets SKIP_LINTER_TEST and points to oxfmt CLI |
| editors/vscode/tests/e2e_server_linter.spec.ts | Adds conditional skip for linter test suite when SKIP_LINTER_TEST is enabled |
| editors/vscode/tests/code_actions.spec.ts | Adds conditional skip for code actions test suite when SKIP_LINTER_TEST is enabled |
| editors/vscode/tests/commands.spec.ts | Conditionally includes oxc.fixAll command in expected commands list and skips its test when SKIP_LINTER_TEST is enabled |
| editors/vscode/tests/e2e_server_formatter.spec.ts | Adds workspace.saveAll() calls after config updates and adjusts timing of sleep in config path test for better synchronization |
| editors/vscode/package.json | Adds oxfmt:build:debug and oxfmt:build:release scripts for building oxfmt with NAPI |
| .github/workflows/ci_vscode.yml | Adds oxfmt/src/lsp/** to CI trigger paths and includes oxfmt build step in CI workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0c703c9 to
258f12a
Compare
258f12a to
b6c682f
Compare
Merge activity
|
b6c682f to
65b8d74
Compare

No description provided.