refactor(vscode): introduce ToolInterface
#15974
Merged
+339
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-editor
This was referenced Nov 22, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
changed the base branch from
11-22-feat_vscode_add_quick_actions_to_status_bar_tooltip
to
graphite-base/15974
Sysix
force-pushed
the
graphite-base/15974
branch
from
559d637 to
4fd88d7
Compare
Sysix
force-pushed
the
11-22-refactor_vscode_introduce_toolinterface_
branch
from
d006a1c to
c4aa9fc
Compare
Sysix
changed the base branch from
graphite-base/15974
to
11-22-feat_vscode_add_quick_actions_to_status_bar_tooltip
graphite-app
bot
changed the base branch from
11-22-feat_vscode_add_quick_actions_to_status_bar_tooltip
to
graphite-base/15974
graphite-app
bot
force-pushed
the
graphite-base/15974
branch
from
4fd88d7 to
3a1d4a9
Compare
graphite-app
bot
force-pushed
the
11-22-refactor_vscode_introduce_toolinterface_
branch
from
c4aa9fc to
eff297e
Compare
graphite-app
bot
force-pushed
the
11-22-refactor_vscode_introduce_toolinterface_
branch
2 times, most recently
from
193ae0b to
3455e6c
Compare
Copilot finished reviewing on behalf of
Sysix
November 23, 2025 15:11
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the VSCode extension's linter functionality by introducing a ToolInterface abstraction. The refactoring moves from function-based exports to a class-based architecture, preparing the codebase for supporting multiple tools (e.g., linter and formatter) with a consistent interface.
Key Changes:
- Introduced
ToolInterfaceas a generic interface for extension tools - Refactored procedural linter code into a
LinterToolclass implementingToolInterface - Moved helper functions to a dedicated
tools/directory structure - Updated imports across the codebase to reflect the new file structure
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/client/tools/ToolInterface.ts | New interface defining the contract for extension tools (activate, deactivate, toggleClient, restartClient, onConfigChange) |
| editors/vscode/client/tools/linter.ts | Refactored linter functionality from procedural functions to a LinterTool class implementing ToolInterface |
| editors/vscode/client/tools/lsp_helper.ts | Moved LSP helper functions (runExecutable, onClientNotification) to the tools directory |
| editors/vscode/client/linter.ts | Removed (functionality moved to tools/linter.ts) |
| editors/vscode/client/extension.ts | Updated to instantiate and use the new LinterTool class instead of importing individual functions |
| editors/vscode/tests/lsp_helper.spec.ts | Updated import path to reference the new location of lsp_helper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
11-22-refactor_vscode_introduce_toolinterface_
branch
from
3455e6c to
6792d16
Compare
camc314
approved these changes
Nov 24, 2025
Contributor
Merge activity
|
> This PR refactors the VSCode extension's linter functionality by introducing a ToolInterface abstraction. The refactoring moves from function-based exports to a class-based architecture, preparing the codebase for supporting multiple tools (e.g., linter and formatter) with a consistent interface.
graphite-app
bot
force-pushed
the
11-22-refactor_vscode_introduce_toolinterface_
branch
from
6792d16 to
e8aa84a
Compare
graphite-app
bot
deleted the
11-22-refactor_vscode_introduce_toolinterface_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.