Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 23, 2025

Added TS2309 error check.

@github-actions github-actions bot added the A-semantic Area - Semantic label Nov 23, 2025
Copy link
Member Author

sapphi-red commented Nov 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 23, 2025

CodSpeed Performance Report

Merging #15992 will not alter performance

Comparing 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports (3748cbb) with main (ef05957)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red marked this pull request as ready for review November 23, 2025 17:08
@sapphi-red sapphi-red requested a review from Dunqing as a code owner November 23, 2025 17:08
Copilot AI review requested due to automatic review settings November 23, 2025 17:08
@sapphi-red sapphi-red requested a review from Boshen November 23, 2025 17:09
Copilot finished reviewing on behalf of sapphi-red November 23, 2025 17:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements TypeScript error TS2309, which detects when an export = statement is used in a module that also contains other exported elements. This is a semantic error in TypeScript because export = (CommonJS-style export) is incompatible with ES6-style exports.

Key Changes:

  • Added semantic check for TS2309 that reports errors when export = coexists with other exports in the same scope
  • Improved test coverage with 15 previously failing test cases now passing (from 57.17% to 57.76%)
  • Implemented recursive checking for nested TypeScript module declarations

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_semantic/src/checker/typescript.rs Implements the core logic for detecting export assignment conflicts, including helper functions for checking statements in programs and module declarations
crates/oxc_semantic/src/checker/mod.rs Integrates the new check into the semantic analysis pipeline, calling it during Program node processing
tasks/coverage/snapshots/parser_typescript.snap Updates test snapshots showing 15 additional negative test cases now correctly reporting TS2309 errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve AI reviews.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 24, 2025

Merge activity

  • Nov 24, 5:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 6:32 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 25, 6:32 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 25, 6:32 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 25, 6:33 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Nov 25, 6:33 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 25, 6:33 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@sapphi-red sapphi-red force-pushed the 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports branch from 3748cbb to f317b33 Compare November 26, 2025 12:33
@sapphi-red sapphi-red requested a review from Boshen November 26, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants