Skip to content

feat(parser): add TS1174 error for classes extending multiple base classes #15993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports
Choose a base branch
from
Open

feat(parser): add TS1174 error for classes extending multiple base classes #15993

wants to merge 1 commit into from
+69 −7

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 23, 2025 •
edited
Loading

Added TS1174 error check.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Nov 23, 2025
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Nov 23, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Nov 23, 2025
Open
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 23, 2025

CodSpeed Performance Report

Merging #15993 will not alter performance

Comparing 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes (3eb5101) with main (ef05957)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports (3748cbb) during the generation of this report, so main (ef05957) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sapphi-red sapphi-red marked this pull request as ready for review November 23, 2025 17:08
@sapphi-red sapphi-red requested a review from Boshen November 23, 2025 17:09
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Nov 24, 2025

Merge activity

  • Nov 24, 5:53 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app graphite-app bot changed the base branch from 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports to graphite-base/15993 November 25, 2025 06:32
@sapphi-red @claude
feat(parser): add TS1174 error for classes extending multiple base cl…
637d155 
…asses

Implement TypeScript error TS1174 which is emitted when a class attempts
to extend multiple base classes using comma-separated syntax (e.g.,
'class C extends A, B { }').

In TypeScript, classes can only extend a single class, unlike interfaces
which can extend multiple interfaces. This implementation:

- Adds the diagnostic message with helpful guidance to use interfaces
  for multiple inheritance
- Checks the extends clause after parsing to detect multiple base classes
- Emits an error for each additional base class beyond the first

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@sapphi-red sapphi-red force-pushed the 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes branch from 3eb5101 to 637d155 Compare November 26, 2025 12:33
@sapphi-red sapphi-red changed the base branch from graphite-base/15993 to 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports November 26, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

0-merge Merge with Graphite Merge Queue A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @Boshen