feat(parser): add diagnostic for expected ident after optional chain

[camchenry]

Currently we just emit "unexpected token", but we actually have a good amount of context here to provide better help + error message.

[camchenry]

• perf(parser): remove bounds check for getting strings from lexer #16135
• feat(parser): add diagnostic for JSX identifiers with hyphens #16133
• feat(parser): add diagnostic for expected ident after optional chain #16132 👈 (View in Graphite)
• feat(parser): improve diagnostic for unexpected optional declarations #16131
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16132 will not alter performance

_{Comparing 11-25-feat_parser_add_diagnostic_for_expected_ident_after_optional_chain (4142b24) with 11-25-feat_parser_improve_diagnostic_for_unexpected_optional_declarations (dfa63e3)}

Summary

✅ 42 untouched
⏩ 3 skipped¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Nov 26, 4:30 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Nov 26, 4:38 AM UTC: Merged by the Graphite merge queue.

[camc314]

should this also consider the optional call expression case?

foo?.()