Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Nov 26, 2025

Instead of just emitting "unexpected token", provide a better error message that says exactly what is wrong and how to fix the error.

Copy link
Member Author

camchenry commented Nov 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Nov 26, 2025
@camchenry camchenry marked this pull request as ready for review November 26, 2025 02:17
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #16133 will not alter performance

Comparing 11-25-feat_parser_add_diagnostic_for_jsx_identifiers_with_hyphens (b3e1014) with main (891e0b4)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on 11-25-feat_parser_add_diagnostic_for_expected_ident_after_optional_chain (4142b24) during the generation of this report, so main (891e0b4) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
Copy link
Member

Boshen commented Nov 26, 2025

Merge activity

  • Nov 26, 4:30 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 4:30 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Nov 26, 9:23 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 26, 9:23 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 26, 9:28 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 11-25-feat_parser_add_diagnostic_for_expected_ident_after_optional_chain branch from 4142b24 to 0549ae5 Compare November 26, 2025 04:33
graphite-app bot pushed a commit that referenced this pull request Nov 26, 2025
Instead of just emitting "unexpected token", provide a better error message that says exactly what is wrong and how to fix the error.
@graphite-app graphite-app bot force-pushed the 11-25-feat_parser_add_diagnostic_for_jsx_identifiers_with_hyphens branch from b3e1014 to 29ff54d Compare November 26, 2025 04:34
Base automatically changed from 11-25-feat_parser_add_diagnostic_for_expected_ident_after_optional_chain to main November 26, 2025 04:38
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
Instead of just emitting "unexpected token", provide a better error message that says exactly what is wrong and how to fix the error.
@graphite-app graphite-app bot force-pushed the 11-25-feat_parser_add_diagnostic_for_jsx_identifiers_with_hyphens branch from 29ff54d to 17a8caa Compare November 26, 2025 09:23
Copilot AI review requested due to automatic review settings November 26, 2025 09:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 17a8caa into main Nov 26, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-25-feat_parser_add_diagnostic_for_jsx_identifiers_with_hyphens branch November 26, 2025 09:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants