test(linter/plugins): Add eslint-plugin-cypress to the conformance suite for JS Plugins#20265
Merged
overlookmotel merged 1 commit intomainfrom Mar 19, 2026
Merged
test(linter/plugins): Add eslint-plugin-cypress to the conformance suite for JS Plugins#20265overlookmotel merged 1 commit intomainfrom
overlookmotel merged 1 commit intomainfrom
Conversation
2674748 to
2870325
Compare
…ite for JS Plugins. This adds eslint-plugin-cypress, based on the same changes from the last 2 additions I've done. See the repo here: https://github.com/cypress-io/eslint-plugin-cypress
22b273f to
c8d405c
Compare
overlookmotel
approved these changes
Mar 19, 2026
Member
overlookmotel
left a comment
There was a problem hiding this comment.
A gloriously uncomplicated implementation on this one! It's so much easier when people use ESLint's RuleTester.
It looks like the 3 failing test cases are due to a bug in TS-ESLint's scopes implementation (which Oxlint uses). I'm still working on confirming that 100%, but that's what it looks like right now.
Member
|
I was wrong. It's a bug (IMO) in the rule: cypress-io/eslint-plugin-cypress#308 |
costajohnt
pushed a commit
to costajohnt/oxc
that referenced
this pull request
Mar 22, 2026
…ite for JS Plugins (oxc-project#20265) This adds eslint-plugin-cypress, based on the same changes from the last 2 additions I've done. See the repo here: https://github.com/cypress-io/eslint-plugin-cypress AI Disclosure: Generated with Claude Code, tested/spot-checked and verified by me (including the SHA hash, of course). ``` ### Rules | Status | Count | % | | ----------------- | ----- | ------ | | Total rules | 12 | 100.0% | | Fully passing | 11 | 91.7% | | Partially passing | 1 | 8.3% | | Fully failing | 0 | 0.0% | | Load errors | 0 | 0.0% | | No tests run | 0 | 0.0% | ### Tests | Status | Count | % | | ----------- | ----- | ------ | | Total tests | 150 | 100.0% | | Passing | 147 | 98.0% | | Failing | 3 | 2.0% | | Skipped | 0 | 0.0% | ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds eslint-plugin-cypress, based on the same changes from the last 2 additions I've done. See the repo here: https://github.com/cypress-io/eslint-plugin-cypress
AI Disclosure: Generated with Claude Code, tested/spot-checked and verified by me (including the SHA hash, of course).