Skip to content

test(linter/plugins): Add eslint-plugin-cypress to the conformance suite for JS Plugins#20265

Merged
overlookmotel merged 1 commit intomainfrom
conformance-cypress
Mar 19, 2026
Merged

test(linter/plugins): Add eslint-plugin-cypress to the conformance suite for JS Plugins#20265
overlookmotel merged 1 commit intomainfrom
conformance-cypress

Conversation

@connorshea
Copy link
Copy Markdown
Member

@connorshea connorshea commented Mar 12, 2026

This adds eslint-plugin-cypress, based on the same changes from the last 2 additions I've done. See the repo here: https://github.com/cypress-io/eslint-plugin-cypress

AI Disclosure: Generated with Claude Code, tested/spot-checked and verified by me (including the SHA hash, of course).

### Rules

| Status            | Count | %      |
| ----------------- | ----- | ------ |
| Total rules       |    12 | 100.0% |
| Fully passing     |    11 |  91.7% |
| Partially passing |     1 |   8.3% |
| Fully failing     |     0 |   0.0% |
| Load errors       |     0 |   0.0% |
| No tests run      |     0 |   0.0% |

### Tests

| Status      | Count | %      |
| ----------- | ----- | ------ |
| Total tests |   150 | 100.0% |
| Passing     |   147 |  98.0% |
| Failing     |     3 |   2.0% |
| Skipped     |     0 |   0.0% |

@connorshea connorshea requested a review from camc314 as a code owner March 12, 2026 04:49
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Mar 12, 2026
@overlookmotel overlookmotel force-pushed the conformance-playwright branch from 2674748 to 2870325 Compare March 19, 2026 18:41
Base automatically changed from conformance-playwright to main March 19, 2026 19:47
…ite for JS Plugins.

This adds eslint-plugin-cypress, based on the same changes from the last
2 additions I've done. See the repo here: https://github.com/cypress-io/eslint-plugin-cypress
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A gloriously uncomplicated implementation on this one! It's so much easier when people use ESLint's RuleTester.

It looks like the 3 failing test cases are due to a bug in TS-ESLint's scopes implementation (which Oxlint uses). I'm still working on confirming that 100%, but that's what it looks like right now.

@overlookmotel overlookmotel merged commit 2c50654 into main Mar 19, 2026
18 checks passed
@overlookmotel overlookmotel deleted the conformance-cypress branch March 19, 2026 23:08
@overlookmotel
Copy link
Copy Markdown
Member

I was wrong. It's a bug (IMO) in the rule: cypress-io/eslint-plugin-cypress#308

costajohnt pushed a commit to costajohnt/oxc that referenced this pull request Mar 22, 2026
…ite for JS Plugins (oxc-project#20265)

This adds eslint-plugin-cypress, based on the same changes from the last
2 additions I've done. See the repo here:
https://github.com/cypress-io/eslint-plugin-cypress

AI Disclosure: Generated with Claude Code, tested/spot-checked and
verified by me (including the SHA hash, of course).

```
### Rules

| Status            | Count | %      |
| ----------------- | ----- | ------ |
| Total rules       |    12 | 100.0% |
| Fully passing     |    11 |  91.7% |
| Partially passing |     1 |   8.3% |
| Fully failing     |     0 |   0.0% |
| Load errors       |     0 |   0.0% |
| No tests run      |     0 |   0.0% |

### Tests

| Status      | Count | %      |
| ----------- | ----- | ------ |
| Total tests |   150 | 100.0% |
| Passing     |   147 |  98.0% |
| Failing     |     3 |   2.0% |
| Skipped     |     0 |   0.0% |
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants