feat(gen-shims): skip generating shims for types containing unexported types #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
force-pushed
the
c/08-21-feat_gen-shims_skip_generating_shims_for_types_containing_unexported_types
branch
from
8c646ae to
8197c31
Compare
Merge activity
|
…d types (#128) microsoft/typescript-go#1505 makes some changes that mean that some functions reference types that aren’t exported, this means that we can’t compile tsgolint anymore 😥 this PR skips generating shims for functions with unexported types, logging a warning to stderr.
graphite-app
bot
force-pushed
the
c/08-21-feat_gen-shims_skip_generating_shims_for_types_containing_unexported_types
branch
from
8197c31 to
334c187
Compare
graphite-app
bot
deleted the
c/08-21-feat_gen-shims_skip_generating_shims_for_types_containing_unexported_types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/typescript-go#1505 makes some changes that mean that some functions reference types that aren’t exported, this means that we can’t compile tsgolint anymore 😥
this PR skips generating shims for functions with unexported types, logging a warning to stderr.