-
-
Notifications
You must be signed in to change notification settings - Fork 22
refactor(tsgolint): update project structure based on new snapshots arch #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tsgolint): update project structure based on new snapshots arch #129
Conversation
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
6bc2f56
to
e627b03
Compare
8c646ae
to
8197c31
Compare
e627b03
to
359bc59
Compare
Merge activity
|
359bc59
to
11cc987
Compare
11cc987
to
a42a169
Compare
a42a169
to
a436a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the tsgolint project structure to adopt a new snapshots-based architecture, replacing the previous service-based approach with session-based project management.
- Migrated from
project.Service
toproject.Session
for project management - Updated API signatures to use abstracted types instead of concrete implementation types
- Removed deprecated project management components and simplified the codebase
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
typescript-go | Updated subproject commit to newer version with snapshots architecture |
shim/tspath/shim.go | Added SplitVolumePath function linkname |
shim/tsoptions/shim.go | Updated function signatures to use ExtendedConfigCache type alias and added new types/functions |
shim/project/shim.go | Major refactor removing legacy service types and adding new session-based types |
shim/project/go.mod | Updated dependency version for go-json-experiment/json |
shim/lsp/lsproto/shim.go | Added HasTextDocumentURI type |
shim/core/shim.go | Added breadth-first search and throttle group types |
shim/compiler/shim.go | Updated function signatures to use ExtendedConfigCache type alias |
patches/0006-patch-improve-perf-of-acquireConfig.patch | Removed performance optimization patch (no longer needed) |
patches/0004-Adapt-project-service-for-single-run-mode.patch | Updated patch metadata and context |
patches/0003-Temporarily-disable-project-cleanup-and-debug-output.patch | Removed patch (no longer needed) |
go.work.sum | Updated dependency checksums |
cmd/tsgolint/service.go | Refactored to use Session instead of Service |
cmd/tsgolint/headless.go | Updated to use new session-based API with proper file handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a436a2b
to
7ef7c35
Compare
closes #131