Skip to content

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Aug 21, 2025

closes #131

Copy link
Contributor Author

camc314 commented Aug 21, 2025


How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch 2 times, most recently from 6bc2f56 to e627b03 Compare August 21, 2025 22:36
@camc314 camc314 force-pushed the c/08-21-feat_gen-shims_skip_generating_shims_for_types_containing_unexported_types branch from 8c646ae to 8197c31 Compare August 21, 2025 22:36
@camc314 camc314 marked this pull request as ready for review August 21, 2025 22:39
@camc314 camc314 force-pushed the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch from e627b03 to 359bc59 Compare August 21, 2025 22:39
@graphite-app graphite-app bot changed the base branch from c/08-21-feat_gen-shims_skip_generating_shims_for_types_containing_unexported_types to graphite-base/129 August 22, 2025 02:32
@Boshen Boshen added the 0-merge label Aug 22, 2025
Copy link
Member

Boshen commented Aug 22, 2025

Merge activity

  • Aug 22, 2:33 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 22, 2:33 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Aug 22, 2:40 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Aug 22, 9:05 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 22, 9:07 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Aug 22, 9:22 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 22, 9:33 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Aug 22, 9:43 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/129 to main August 22, 2025 02:39
@graphite-app graphite-app bot removed the 0-merge label Aug 22, 2025
@camc314 camc314 requested a review from Copilot August 22, 2025 09:05
@camc314 camc314 force-pushed the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch from 359bc59 to 11cc987 Compare August 22, 2025 09:05
Copilot

This comment was marked as outdated.

@camc314 camc314 removed the 0-merge label Aug 22, 2025
@camc314 camc314 force-pushed the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch from 11cc987 to a42a169 Compare August 22, 2025 09:10
@camc314 camc314 requested a review from Copilot August 22, 2025 09:15
Copilot

This comment was marked as outdated.

@camc314 camc314 force-pushed the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch from a42a169 to a436a2b Compare August 22, 2025 09:21
@camc314 camc314 requested a review from Copilot August 22, 2025 09:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the tsgolint project structure to adopt a new snapshots-based architecture, replacing the previous service-based approach with session-based project management.

  • Migrated from project.Service to project.Session for project management
  • Updated API signatures to use abstracted types instead of concrete implementation types
  • Removed deprecated project management components and simplified the codebase

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
typescript-go Updated subproject commit to newer version with snapshots architecture
shim/tspath/shim.go Added SplitVolumePath function linkname
shim/tsoptions/shim.go Updated function signatures to use ExtendedConfigCache type alias and added new types/functions
shim/project/shim.go Major refactor removing legacy service types and adding new session-based types
shim/project/go.mod Updated dependency version for go-json-experiment/json
shim/lsp/lsproto/shim.go Added HasTextDocumentURI type
shim/core/shim.go Added breadth-first search and throttle group types
shim/compiler/shim.go Updated function signatures to use ExtendedConfigCache type alias
patches/0006-patch-improve-perf-of-acquireConfig.patch Removed performance optimization patch (no longer needed)
patches/0004-Adapt-project-service-for-single-run-mode.patch Updated patch metadata and context
patches/0003-Temporarily-disable-project-cleanup-and-debug-output.patch Removed patch (no longer needed)
go.work.sum Updated dependency checksums
cmd/tsgolint/service.go Refactored to use Session instead of Service
cmd/tsgolint/headless.go Updated to use new session-based API with proper file handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app graphite-app bot force-pushed the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch from a436a2b to 7ef7c35 Compare August 22, 2025 09:33
@graphite-app graphite-app bot merged commit 7ef7c35 into main Aug 22, 2025
7 checks passed
@graphite-app graphite-app bot deleted the c/08-21-refactor_tsgolint_update_project_structure_based_on_new_snapshots_arch branch August 22, 2025 09:43
@graphite-app graphite-app bot removed the 0-merge label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants