Skip to content

Move SWITCH_ZONE_BASEBOARD_FILE to sled-agent-types#7669

Merged
papertigers merged 1 commit intomainfrom
spr/papertigers/move-switch_zone_baseboard_file-to-sled-agent-types
Feb 27, 2025
Merged

Move SWITCH_ZONE_BASEBOARD_FILE to sled-agent-types#7669
papertigers merged 1 commit intomainfrom
spr/papertigers/move-switch_zone_baseboard_file-to-sled-agent-types

Conversation

@papertigers
Copy link
Copy Markdown
Contributor

@papertigers papertigers commented Feb 27, 2025

This allows us to remove the dependency on sled-agent in zone-setup, which is pulled in for a single type definition.

Without this change a debug build currently relies on libnvme.so, while the compiler is able to elide this library on a release build:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 14s
Error: Found library issues with the following:
nexus
        UNEXPECTED dependency on libsqlite3.so.0
omicron-dev
        UNEXPECTED dependency on libsqlite3.so.0
zone-setup
        NEEDS libnvme.so.1 but is not allowed


If depending on a new library was intended please add it to xtask.toml

And after this change we no longer depend on it in debug/release builds:

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s
Error: Found library issues with the following:
nexus
        UNEXPECTED dependency on libsqlite3.so.0
omicron-dev
        UNEXPECTED dependency on libsqlite3.so.0


If depending on a new library was intended please add it to xtask.toml

Created using spr 1.3.6-beta.1
@papertigers papertigers merged commit 5c94119 into main Feb 27, 2025
17 checks passed
@papertigers papertigers deleted the spr/papertigers/move-switch_zone_baseboard_file-to-sled-agent-types branch February 27, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants