Merged
Conversation
iliana
force-pushed
the
iliana/tufaceous-split
branch
from
72492a2 to
22fd0c6
Compare
sunshowers
approved these changes
Feb 27, 2025
labbott
approved these changes
Feb 28, 2025
Contributor
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
LGTM, let me know if I can help test anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to use tufaceous in other tooling that will live outside Omicron and it's reached a reasonable level of stability. Let's split it out so that consumers don't need to also depend on omicron-common.
Companion PR: oxidecomputer/tufaceous#1
This is ready for review; I've only marked it as draft to remind myself that I need to merge the companion PR and update the branch name to
mainin Cargo.toml here.