Merged
Conversation
labbott
reviewed
Feb 28, 2025
Collaborator
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
This looks great, thanks for doing the work to bring this over
iliana
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Mar 2, 2025
We want to use tufaceous in other tooling that will live outside Omicron and it's reached a reasonable level of stability. Let's split it out so that consumers don't need to also depend on omicron-common. Companion PR: oxidecomputer/tufaceous#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tufaceous-libandtufaceousare more or less copied over as-is.omicron-brand-metadatais moved here and is renamedtufaceous-brand-metadatato reflect the fact that we're using extensions of the original brand metadata that were first defined in tufaceous.tufaceous-artifactis the new home for the struct crates fromomicron-commonthat are needed bytufaceous-lib.88a368f is the code copied over from Omicron as-is; a987c58 is the "real" diff of changes made to fit this workspace scheme. I also went through and made the imports and license headers a bit more consistent.
The Cargo.lock is originally sourced from Omicron, so all dependencies should be at the same versions.
Companion PR: oxidecomputer/omicron#7670