new fn try_instance_simulate should be behind the multicast gate#9763
Merged
Nieuwejaar merged 1 commit intomainfrom Jan 31, 2026
Merged
new fn try_instance_simulate should be behind the multicast gate#9763Nieuwejaar merged 1 commit intomainfrom
Nieuwejaar merged 1 commit intomainfrom
Conversation
Contributor
Author
|
Between the time I started my last test run and pushed the dendrite bump, Zeeshan snuck in a PR with a new function that also needs to be behind the |
bnaecker
approved these changes
Jan 30, 2026
| // This is currently only consumed by tests behind the multicast feature gate. | ||
| // If/when it has another consumer, this cfg can be removed. | ||
| #[cfg(feature = "multicast")] | ||
| pub async fn try_instance_simulate( |
Collaborator
There was a problem hiding this comment.
@Nieuwejaar apologies, as I had finally had review on the other work (and it came in before). Minor, but, should we just make this #[allow(dead_code)] as it's a general function.
Collaborator
There was a problem hiding this comment.
But, minor either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.