Add withConjureErrorParameterFormat option to WithClientOptions
#3192
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
[skip ci]
bjlaub
reviewed
Aug 15, 2025
client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java
Outdated
Show resolved
Hide resolved
mpritham
changed the title
withConjureErrorParameterSerializationFormat option to WithClientOptionswithConjureErrorParameterFormat option to WithClientOptions
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
mpritham
commented
Aug 18, 2025
| @@ -3,6 +3,7 @@ apply plugin: 'org.revapi.revapi-gradle-plugin' | |||
|
|
|||
| dependencies { | |||
| api 'com.palantir.conjure.java.api:service-config' | |||
| api 'com.palantir.conjure.java.api:errors' | |||
There was a problem hiding this comment.
This is needed because ConjureErrorParameterFormat is defined in com.palantir.conjure.java.api:errors
aldexis
reviewed
Aug 20, 2025
Comment on lines
+88
to
+91
| - code: "java.method.removed" | ||
| old: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions<T>::withConjureErrorParameterSerializationFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" | ||
| justification: "Adding method to allow clients to request error parameter serialization\ | ||
| \ format" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?