Skip to content

Add withConjureErrorParameterFormat option to WithClientOptions #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
+14 −0
Open

Add withConjureErrorParameterFormat option to WithClientOptions #3192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
392ded2
wip
Jul 28, 2025
292dc63
Add withConjureErrorParameterSerializationFormat to WithClientOptions
Jul 29, 2025
c348f88
revapi
Aug 12, 2025
8c79e9c
Release 8.24.0-rc1
svc-autorelease Aug 14, 2025
b995922
review change
Aug 18, 2025
e3f7b7b
update revapi
Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .palantir/revapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,13 @@ acceptedBreaks:
- code: "java.class.removed"
old: "enum com.palantir.conjure.java.server.jersey.ErrorCause"
justification: "ErrorCause is never used by consumers"
"8.24.0-rc1":
com.palantir.conjure.java.runtime:client-config:
- code: "java.method.addedToInterface"
new: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions<T>::withConjureErrorParameterFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)"
justification: "Adding method to allow clients to request error parameter serialization\
\ format"
- code: "java.method.removed"
old: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions<T>::withConjureErrorParameterSerializationFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)"
justification: "Adding method to allow clients to request error parameter serialization\
\ format"
Comment on lines +88 to +91
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems weird?

1 change: 1 addition & 0 deletions client-config/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apply plugin: 'org.revapi.revapi-gradle-plugin'

dependencies {
api 'com.palantir.conjure.java.api:service-config'
api 'com.palantir.conjure.java.api:errors'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because ConjureErrorParameterFormat is defined in com.palantir.conjure.java.api:errors

api 'com.palantir.tritium:tritium-registry'
api 'com.google.errorprone:error_prone_annotations'
api 'com.palantir.refreshable:refreshable'
Expand Down
3 changes: 3 additions & 0 deletions client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.palantir.conjure.java.api.config.service.ServiceConfiguration;
import com.palantir.conjure.java.api.config.service.ServicesConfigBlock;
import com.palantir.conjure.java.api.config.service.UserAgent;
import com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat;
import com.palantir.conjure.java.client.config.ClientConfiguration;
import com.palantir.conjure.java.client.config.HostEventsSink;
import com.palantir.conjure.java.client.config.NodeSelectionStrategy;
Expand Down Expand Up @@ -88,6 +89,8 @@ public interface WithClientOptions<T> {

/** Per-host success/failure information will be recorded to this sink. */
T withHostEventsSink(HostEventsSink hostEventsSink);

T withConjureErrorParameterFormat(ConjureErrorParameterFormat format);
}

public interface ToReloadingFactory<U> {
Expand Down