Draft: Card why #16
Draft: Card why #16
Conversation
✅ Deploy Preview for rubycon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🤖 Hi @Fedois, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Fedois, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Rubycon Italy website by adding a new section that explains the core reasons and vision behind the conference. This involves both updating the site's data configuration and implementing the corresponding display logic on the 'about' page.
Highlights
- New "Why" Section Added: Introduced a dedicated "why" section in the site configuration (
_config.yml) to articulate the motivations behind Rubycon Italy. - Dynamic Rendering of New Section: Implemented the front-end logic in
_includes/about.htmlto dynamically display the content of the new "why" section on the 'about' page. - Description Correction in Config: Corrected an existing description for "ruby at the core" in
_config.ymlby uncommenting the intended text and commenting out a temporary one.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds a new 'Why Rubycon Italy' section to the about page, defining the content in _config.yml and rendering it in _includes/about.html. The changes are functional, but I have a couple of suggestions to improve maintainability and consistency. I've pointed out some duplicated code in the HTML which could be refactored into a reusable include, and a minor inconsistency in the capitalization of titles in the configuration file. Addressing these points will make the code cleaner and easier to manage in the long run.
rubycon.it/_config.yml
Outdated
| - title: beyond just code | ||
| icon: handshake-angle | ||
| description: "Ruby in Italy shouldn’t just be a language: it should be connections, opportunities, and people supporting each other." |
There was a problem hiding this comment.
There's an inconsistency in the capitalization of the title fields within the why section. The title 'beyond just code' is in all lowercase, while other titles like 'Giving a voice to the unheard' and 'Creating a real community' use sentence case. For consistency in how these titles are displayed on the website, consider using a consistent capitalization scheme for all of them, for example, 'Beyond just code'.
- title: Beyond just code
icon: handshake-angle
description: "Ruby in Italy shouldn’t just be a language: it should be connections, opportunities, and people supporting each other."
rubycon.it/_includes/about.html
Outdated
| <div class="bg-white p-8 rounded-lg shadow-md text-center hover:shadow-lg transition" data-aos="fade-up"> | ||
| <div class="bg-red-100 w-16 h-16 mx-auto rounded-full flex items-center justify-center mb-4"> | ||
| <i class="fas fa-{{ card.icon }} text-red-800 text-2xl"></i> | ||
| </div> | ||
| <h3 class="text-xl font-bold mb-3">{{ card.title }}</h3> | ||
| <p class="text-gray-600">{{ card.description }}</p> | ||
| </div> |
There was a problem hiding this comment.
This block of code for rendering a card is a duplicate of the one used for the site.about cards on lines 4-10. Duplicating code can make future updates more difficult, as changes would need to be applied in multiple places.
To improve maintainability, I recommend extracting this card layout into a reusable Jekyll include. This would centralize the card's HTML structure, making it easier to manage and update. For instance, you could create a new include file (e.g., _includes/card.html) with the card's markup and then call it from both loops like this:
{% for card in site.why %}
{% include card.html title=card.title icon=card.icon description=card.description %}
{% endfor %}As I cannot suggest creating a new file in this review, I'll leave the implementation details to you, but strongly recommend this refactoring to avoid code duplication.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request adds a new "Why Rubycon Italy" section to the website, explaining the motivation behind the conference. The changes are well-implemented and follow the existing structure of the website.
🔍 General Feedback
- The new section provides valuable context for potential attendees and sponsors.
- The code is clean and easy to understand.
- I have suggested some minor capitalization and grammar fixes to improve consistency and readability.
There was a problem hiding this comment.
📋 Review Summary
This pull request introduces a new "Why Rubycon Italy" section to the website, populated with data from the _config.yml file. The changes are well-structured and align with the existing codebase.
🔍 General Feedback
- The new section is implemented consistently with the existing "About" section, promoting code reusability and maintainability.
- The use of data-driven content from
_config.ymlis a good practice, making it easy to update the content without touching the HTML. - The HTML and CSS classes are clean and follow the existing style.
Overall, this is a great addition to the website!
| description: learn about the latest trends and best practices in ruby, rails, and related technologies from industry leaders. | ||
| # description: Created by Ruby enthusiasts for Ruby enthusiasts. # Add MINASWAN and Italian hospitality. |
There was a problem hiding this comment.
🟢 It's good practice to remove commented-out code to keep the configuration file clean.
There was a problem hiding this comment.
I disagree. Unless we move to a TODO/issue
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
|
Per me e' un po' bloated. 3 in linea ci stanno, ma 6 sono troppe. Secondo me un link a "Why do we do it?" che punta all'articolo che ho appena pushato appesantisce MENO il tutto @Fedois |
|
|
@Fedois cosa manca ancora? Leggo draft e faccio fatica a mergiare. |
Non ho pensato bene a cosa scrivere nelle nuove cards. Ma intanto esistono