Skip to content

Draft: Card why #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Draft: Card why #16

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2caca7f
added variable why
Fedois Sep 5, 2025
e7f49a0
fix margin bethween cards
Fedois Sep 5, 2025
33751c5
new file card_about.html
Fedois Sep 6, 2025
c5bb935
Merge branch 'main' into card_why
Fedois Sep 7, 2025
e10f187
added slug for why-are-we-doing-this
Fedois Sep 7, 2025
75e9d2b
removed variable why in _config.yml
Fedois Sep 7, 2025
bf98789
Merge branch 'main' into card_why
Fedois Sep 9, 2025
05ca56f
changed sentence
Fedois Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions rubycon.it/_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,24 @@ navigation:
about:
- title: ruby at the core
icon: gem
#description: learn about the latest trends and best practices in ruby, rails, and related technologies from industry leaders.
description: Created by Ruby enthusiasts for Ruby enthusiasts. # Add MINASWAN and Italian hospitality.
description: learn about the latest trends and best practices in ruby, rails, and related technologies from industry leaders.
# description: Created by Ruby enthusiasts for Ruby enthusiasts. # Add MINASWAN and Italian hospitality.
Comment on lines +87 to +88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 It's good practice to remove commented-out code to keep the configuration file clean.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. Unless we move to a TODO/issue

- title: Community connections
icon: users
description: meet fellow ruby developers, share ideas, and build relationships with collaborators, employers, and enthusiasts.
- title: Italian atmosphere
icon: utensils
description: experience the warmth of Italy through local culture, food, and hospitality while attending the conference in Rimini.
why:
- title: Giving a voice to the unheard
icon: globe
description: In Italy there are great Ruby developers, but nobody knows them abroad. Rubycon is also for them.
- title: beyond just code
icon: handshake-angle
description: "Ruby in Italy shouldn’t just be a language: it should be connections, opportunities, and people supporting each other."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency in the capitalization of the title fields within the why section. The title 'beyond just code' is in all lowercase, while other titles like 'Giving a voice to the unheard' and 'Creating a real community' use sentence case. For consistency in how these titles are displayed on the website, consider using a consistent capitalization scheme for all of them, for example, 'Beyond just code'.

  - title: Beyond just code
    icon: handshake-angle
    description: "Ruby in Italy shouldn’t just be a language: it should be connections, opportunities, and people supporting each other."

- title: Creating a real community
icon: heart
description: In Italy there’s no real Ruby community yet. Rubycon wants to change that.
speakers:
# - avatar: '/assets/images/speakers/carmine-paolino.jpg'
# full_name: Carmine Paolino
Expand Down
13 changes: 13 additions & 0 deletions rubycon.it/_includes/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,19 @@ <h3 class="text-xl font-bold mb-3">{{ card.title }}</h3>
</div>
{% endfor %}
</div>

<h3 class="text-xl max-w-3xl mx-auto text-center my-6" data-aos="fade-up">And why rubycon italy</h3>
<div class="grid md:grid-cols-3 gap-10 mb-16">
{% for card in site.why %}
<div class="bg-white p-8 rounded-lg shadow-md text-center hover:shadow-lg transition" data-aos="fade-up">
<div class="bg-red-100 w-16 h-16 mx-auto rounded-full flex items-center justify-center mb-4">
<i class="fas fa-{{ card.icon }} text-red-800 text-2xl"></i>
</div>
<h3 class="text-xl font-bold mb-3">{{ card.title }}</h3>
<p class="text-gray-600">{{ card.description }}</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block of code for rendering a card is a duplicate of the one used for the site.about cards on lines 4-10. Duplicating code can make future updates more difficult, as changes would need to be applied in multiple places.

To improve maintainability, I recommend extracting this card layout into a reusable Jekyll include. This would centralize the card's HTML structure, making it easier to manage and update. For instance, you could create a new include file (e.g., _includes/card.html) with the card's markup and then call it from both loops like this:

{% for card in site.why %}
    {% include card.html title=card.title icon=card.icon description=card.description %}
{% endfor %}

As I cannot suggest creating a new file in this review, I'll leave the implementation details to you, but strongly recommend this refactoring to avoid code duplication.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

{% endfor %}
</div>
{% endcapture %}

{% include section.html
Expand Down
Loading